[three] r155

[Methuselah96]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: r155 three-types/three-ts-types#537
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@Methuselah96 Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• three — on npm, on unpkg (author is owner)
  • owner-approval: @joshuaellis
  • Config files to check:
    • three/OTHER_FILES.txt: not the expected form and not moving towards it

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ A DT maintainer needs to approve changes which affect module config files

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 66199,
  "author": "Methuselah96",
  "headCommitOid": "ee67ba12043d979a9183a4f34c471446559a7d14",
  "mergeBaseOid": "0a4287274e3f87242b82f04905c02aec3d6c3a5f",
  "lastPushDate": "2023-07-28T02:28:37.000Z",
  "lastActivityDate": "2023-07-31T18:19:16.000Z",
  "mergeOfferDate": "2023-07-31T18:04:21.000Z",
  "mergeRequestDate": "2023-07-31T18:19:16.000Z",
  "mergeRequestUser": "Methuselah96",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "three",
      "kind": "edit",
      "files": [
        {
          "path": "types/three/OTHER_FILES.txt",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-other_filestxt) and not moving towards it"
        },
        {
          "path": "types/three/examples/jsm/controls/OrbitControls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/csm/CSM.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/interactive/HTMLMesh.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/math/MeshSurfaceSampler.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/misc/RollerCoaster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/nodes/loaders/NodeObjectLoader.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/objects/ReflectorForSSRPass.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/postprocessing/AfterimagePass.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/postprocessing/HalftonePass.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/postprocessing/OutputPass.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/postprocessing/RenderPixelatedPass.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/postprocessing/SSAOPass.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/postprocessing/SSRPass.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/postprocessing/TAARenderPass.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/postprocessing/TexturePass.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/utils/BufferGeometryUtils.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/examples/jsm/webxr/XRPlanes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/Three.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/core/BufferAttribute.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/core/RenderTarget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/extras/core/ShapePath.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/helpers/BoxHelper.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/loaders/ObjectLoader.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/materials/Material.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/objects/Group.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/renderers/WebGLRenderTarget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/renderers/WebGLRenderer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/renderers/webgl/WebGLAttributes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/renderers/webgl/WebGLCapabilities.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/renderers/webgl/WebGLState.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/test/integration/three-examples/misc_boxselection.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/misc_controls_arcball.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/misc_controls_drag.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/misc_controls_fly.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/misc_controls_pointerlock.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/misc_controls_transform.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl2_materials_texture3d_partialupdate.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl2_multiple_rendertargets.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl2_volume_instancing.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl_buffergeometry_glbufferattribute.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl_buffergeometry_instancing_interleaved.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl_camera.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl_geometries_parametric.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl_gpgpu_water.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl_postprocessing_pixel.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl_postprocessing_ssr.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl_shadowmap_csm.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webgl_shadowmap_progressive.ts",
          "kind": "test"
        },
        {
          "path": "types/three/test/integration/three-examples/webxr_ar_lighting.ts",
          "kind": "test"
        },
        {
          "path": "types/three/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "joshuaellis",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2023-07-31T18:03:36.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "joshuaellis",
      "date": "2023-07-28T07:07:19.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1654884819,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @joshuaellis — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[DangerBotOSS]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

three (unpkg)

was missing the following properties:

1. CompressedCubeTexture

Generated by 🚫 dangerJS against ee67ba1

[typescript-bot]

@Methuselah96: Everything looks good here. I am ready to merge this PR (at ee67ba1) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@joshuaellis: you can do this too.)

[Methuselah96]

Ready to merge