This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
chore: Replace most usages of "which" with "that" #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why this didn't fail before, but all of the baselines that include this text have to be updated to be passing. |
|
@jakebailey I updated the baselines with |
|
I think you missed merging from master before that, sorry! |
|
@jakebailey How's this? |
jakebailey
approved these changes
Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some bad grammar in the DefinitelyTyped repo comments, so I've created this PR to fix it.
Most places in this code that use "which" should use "that". "that" is used in restrictive clauses, and "which" is used in nonrestrictive clauses.
More info about the grammar: https://www.dictionary.com/e/that-vs-which/