fix: prevent logo.dev banner from shrinking on smaller screens #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a responsive design issue where the logo.dev banner was shrinking on smaller screens, ensuring consistent banner dimensions across all device breakpoints.
- Updated container padding to use more responsive values across breakpoints
- Modified grid gap spacing for better layout on smaller screens
- Enhanced banner styling with flexbox alignment and adjusted padding
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| <div className="flex-shrink-0"> | ||
| <a className="flex gap-1 w-fit text-lg border-2 border-border shadow-shadow pl-2 pr-4 rounded-md bg-secondary-background text-foreground" href="https://logo.dev"><Image src={"https://img.logo.dev/logo.dev?token=pk_Ovv0aVUwQNK80p_PGY_xcg"} className="rounded-md" alt="Logo" width={30} height={30} /> Logos provided by Logo.dev</a> | ||
| <a className="flex items-center gap-1 text-lg border-2 border-border shadow-shadow px-1 rounded-md bg-secondary-background text-foreground" href="https://logo.dev"><Image src={"https://img.logo.dev/logo.dev?token=pk_Wk4d-LNEStqzZmztHBp8Jw"} className="rounded-md" alt="Logo" width={30} height={30} /> Logos provided by Logo.dev</a> |
There was a problem hiding this comment.
[nitpick] The padding change from pl-2 pr-4 to px-1 reduces the horizontal padding significantly (from 8px left + 16px right to 4px both sides). This might make the banner text too cramped. Consider using px-2 or px-3 to maintain adequate spacing while still preventing shrinking issues.
Suggested change
| <a className="flex items-center gap-1 text-lg border-2 border-border shadow-shadow px-1 rounded-md bg-secondary-background text-foreground" href="https://logo.dev"><Image src={"https://img.logo.dev/logo.dev?token=pk_Wk4d-LNEStqzZmztHBp8Jw"} className="rounded-md" alt="Logo" width={30} height={30} /> Logos provided by Logo.dev</a> | |
| <a className="flex items-center gap-1 text-lg border-2 border-border shadow-shadow px-3 rounded-md bg-secondary-background text-foreground" href="https://logo.dev"><Image src={"https://img.logo.dev/logo.dev?token=pk_Wk4d-LNEStqzZmztHBp8Jw"} className="rounded-md" alt="Logo" width={30} height={30} /> Logos provided by Logo.dev</a> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Related Issue
Closes #73
Type of Change
Checklist