Move lint script to sitting under npm-run-all, to allow parallel runners
#517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short introduction
Introduce
npm-run-allto allow concurrent or parallel scripts, and defaultsnpm run lintto use the parallel feature.Description
Some scripts can take time to run in a large project, when the same processing needs to cover the same set of files, time compounds. By running in parallel this time can (usually) be cut down heavily.
This stood between
concurrently(used in other projects), andnpm-run-all. I've gone with the latter due to some longstanding reported bugs with the first that indicate if there's failures in multiple jobs it may not bubble up failures, and give false positives, but this can of course be re-evaluated in the future if need be, but doing it this way also aligns us with what WordPress uses (and staying close to WordPress Core where possible is always a boon).See #451 for associated enhancement ticket.