Exotic methods support #567
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have this
richarddd
approved these changes
Dec 8, 2025
|
|
||
| let crate_name = format_ident!("{}", crate_ident()?); | ||
| let class_name = get_class_name(&self_ty); | ||
| let module_name = format_ident!("__impl_exotic_{}__", class_name); |
Collaborator
There was a problem hiding this comment.
Should we consolidate this with the one in class to avoid duplication?
Collaborator
Author
There was a problem hiding this comment.
I will rework this I am not satisfied. I think I can use the same trick we are using for the constructor with the double ref specialization.
Comment on lines
+707
to
+714
| match crate::util::catch_unwind(f) { | ||
| Ok(x) => x, | ||
| Err(e) => unsafe { | ||
| self.get_opaque().set_panic(e); | ||
| qjs::JS_Throw(self.as_ptr(), qjs::JS_MKVAL(qjs::JS_TAG_EXCEPTION, 0)); | ||
| -1 | ||
| }, | ||
| } |
Collaborator
There was a problem hiding this comment.
This is exact duplicate of handle_panic. Can we use an inner method?
Collaborator
Author
There was a problem hiding this comment.
I can check, dont remember why it was done like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #497