shipyard rewrite/port#1171
shipyard rewrite/port#1171Axionyxx merged 19 commits intoDeltaV-Station:masterfrom deltanedas:shipyard-ops
Conversation
|
UI code got changed with the incoming merge, this will have to wait until after that is merged |
|
yep has a comment to update when merged |
Axionyxx
left a comment
There was a problem hiding this comment.
I'm gonna request 2 things here.
An arbitrage test, and a test that makes sure shuttles are valid (if there isn't already a test that does this.)
as in having != 1 grids? shuttles being loadable is tested already |
Stuff like that, yes. Along with making sure there's a shuttle console, and at least 1 dock |
|
Shipyard isn't meant to be obtainable, im pretty sure it's one of the consoles meant to be mapped into bridge, might add it to shuttle creation though |
|
yeah mapping being in locker or research whatevers best |
Axionyxx
left a comment
There was a problem hiding this comment.
Fix all arbitrages and I'll approve
Was previously mapped on the bridge |
|
We should add warp points to all the shuttles too. Can be in a follow up PR but should be done eventually. |
When thats done, it should be added to the tests too. Ensure the shuttles always have a warp point |
|
But should probably be a seperate pr lol |
|
test itself has dirty disposing but theres no arbitrage, can fix test now or later |
Axionyxx
left a comment
There was a problem hiding this comment.
One small nitpick, lgtm otherwise
# Description This is but a small update in the campaign to, "Make people hate Salvage less". This time, by adding Gold, Silver, and Uranium to the list of raw materials that can be ordered by Logi. This serves as an extremely useful failsafe for in the event that Salvage is Unwilling/Dead/Incompetent/Shitters and failing to provide these raw materials to the station. Now Logi can throw away station money at getting these valuable materials. This is also extremely useful, since by ordering Uranium, it's possible for Logi to provide spare fuel for Engineering on the newly updated Saltern map. Simple-Station/Einstein-Engines#1170 Which no longer has an AME, and instead contains a dedicated Generator Room to serve as backup power. One crate of Uranium can provide Saltern with power for up to 30 minutes. Longer if Engineering correctly sets up the Solar arrays. <details><summary><h1>Media</h1></summary> <p>  </p> </details> # Changelog :cl: - add: Cargo can now order crates of Uranium, Gold, and Silver. This is still far more expensive than getting the materials from Salvage, but serves as an incredibly useful failsafe in the event Salvage is Unwilling/Dead/Incompetent/Shitters.
About the PR
port shipyard from pre rebase, but:
once it enters ftl space the temporary map gets deleted
currently unobtainable i forgor how its meant to be gotten
also someone needs to look over the prices a lot of them seem insanely high, maybe copy frontier
Media
temp map gets created then deleted after it ftls

ship automatically docks, no stations have the funny docks mapped so it will basically be random

ships have name and a random id similar to frontier

Ship changes
all ships:
invalidetc from the ymlbarge:
helix:
pulse: