Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port painkillers and antidepressants #1243

Merged
merged 4 commits into from
May 23, 2024
Merged

port painkillers and antidepressants #1243

merged 4 commits into from
May 23, 2024

Conversation

MilonPL
Copy link
Member

@MilonPL MilonPL commented May 23, 2024 •
edited
Loading

About the PR

Ported from Cosmatic Drift. Adds 3 painkillers and 6 antidepressants, as well as a chemical for managing addictions. They give you RP prompts that you might or might not follow. They shouldn't be too intrusive. THC, Space Drugs, Desoxyephedrine and Impedrezene were also made addictive.

Why / Balance

These reagents are primarily for RP and do not provide any mechanical advantages. With the Submarine station and the psych ward, I think it has great potential for medical RP. There is a psychologist job already, might as well give them something to prescribe.

Media

obraz_2024-05-23_170647855
obraz_2024-05-23_170707424
obraz_2024-05-23_170711771
obraz_2024-05-23_170715949
obraz_2024-05-23_170719954
obraz_2024-05-23_170725573
obraz_2024-05-23_170742229
obraz_2024-05-23_170745825
obraz_2024-05-23_170749405
obraz_2024-05-23_170753424

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Added new anxiety meds, antidepressants and painkillers. Psychologists rejoice!
  • add: THC, Space Drugs, Desoxyephedrine and Impedrezene are now addictive.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Localization Changes any ftl files labels May 23, 2024
@Bonktrauma
Copy link
Contributor

Bonktrauma commented May 23, 2024 •
edited
Loading

YES, PLEASE. I LOVE PSYCH RP

@noctyrnal
Copy link
Contributor

Holy shit fuck yeah

MilonPL added 2 commits May 23, 2024 19:15
@MilonPL
make more chems addictive
55afc17 
makes THC, Space Drugs, Impedrezne and Desoxyephedrine all addictive
@MilonPL
move CD files to the correct folder, add deltav markings, fix guidebo…
6096e57 
…ok entries
@IamVelcroboy
Copy link
Member

Maybe beyond scope of this PR but if these get approved, it would be nice to have some pre-filled pills/containers for mapping. Could potentially add to the random pill container as well.

A-z-z-y
A-z-z-y approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@A-z-z-y A-z-z-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I love the role-play aspects PRs like this provide :)

(also, psych is great)

@A-z-z-y A-z-z-y merged commit 336ae81 into DeltaV-Station:master May 23, 2024
11 checks passed
@dffdff2423
Copy link
Contributor

Oh god, I just discovered this exists. Most of these are from CD's early days when we had much more lax coding standards. The addiction system is stupid and has been something I have wanted to overhaul for a half a year at this point. Many of the chems are not balanced around a environment where the playerbase cannot be trusted to not use them for antagonistic activity.

@MilonPL
Copy link
Member Author

MilonPL commented Sep 20, 2024

Oh god, I just discovered this exists. Most of these are from CD's early days when we had much more lax coding standards. The addiction system is stupid and has been something I have wanted to overhaul for a half a year at this point. Many of the chems are not balanced around a environment where the playerbase cannot be trusted to not use them for antagonistic activity.

Yeah the players have figured out how to mix it into a deadly poison already. I've been planning on reworking it into StatusEffects for a while now.

@Avalon-Proto
Copy link
Contributor

Oh god, I just discovered this exists. Most of these are from CD's early days when we had much more lax coding standards. The addiction system is stupid and has been something I have wanted to overhaul for a half a year at this point. Many of the chems are not balanced around a environment where the playerbase cannot be trusted to not use them for antagonistic activity.

Its Honestly kinda funny, it took people like a day after this was merged to figure out how to make some absolutely evil poisons out of these chems.

@deltanedas
Copy link
Member

i love my psych med 1 shot stuns and kills

@Radezolid Radezolid mentioned this pull request Nov 22, 2024
Merged
2 tasks
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
@sleepyyapril @EmoGarbage404
Mass Bug Fixing (DeltaV-Station#1256)
41501bd 
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Mass bug fixing, for bugs related to DeltaV-Station#1220.
Feel free to link or send bugs.

Fix list:
- DeltaV-Station#1242 
- DeltaV-Station#1243 
- DeltaV-Station#1244
- space-wizards/space-station-14#28084
- space-wizards/space-station-14#28282
- Actually fixed PirateRadioSpawnRule heisentest (with a bandaid) (I
cancel if it's 0)
- Simple-Station/Einstein-Engines#1263

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- fix: Fixed chair visuals drawing depth wrongly if you sat in a
north-facing chair.
- fix: Fixed buckling doing several buckles each time you did one.
- fix: Fixed the magic mirror.
- fix: Fixed beds re-positioning you every few seconds.
- fix: Fixed E not opening containers that are in another container.
- fix: Fixed disposal systems not flushing or ejecting properly.

---------

Co-authored-by: sleepyyapril <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>
Co-authored-by: Nemanja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DangerRevolution DangerRevolution DangerRevolution left review comments

@A-z-z-y A-z-z-y A-z-z-y approved these changes

Assignees
No one assigned
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@MilonPL @Bonktrauma @noctyrnal @IamVelcroboy @dffdff2423 @Avalon-Proto @deltanedas @A-z-z-y @DangerRevolution