Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak event weights #1253

Merged
merged 3 commits into from
May 26, 2024
Merged

Tweak event weights #1253

merged 3 commits into from
May 26, 2024

Conversation

therealDLondon
Copy link
Member

@therealDLondon therealDLondon commented May 25, 2024

About the PR

Slightly edited event weights to fit the current meta and balance

Why / Balance

Various minplayers, mintimes, and weights were changed

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Tweaked event balance. The vents spew sludge more often now!
  • tweak: Mid-Round zombie outbreaks cause 1 more initial infected
  • add: Added the dreaded clown spiders

@github-actions github-actions bot added the Changes: YML Changes any yml files label May 25, 2024
Co-authored-by: Null <[email protected]>
Signed-off-by: therealDLondon <[email protected]>
Co-authored-by: Null <[email protected]>
Signed-off-by: therealDLondon <[email protected]>
@DangerRevolution
Copy link
Contributor

Cluwn return is crazy, there should probably be a changelog entry for every event change especially Cluwn

also this FINALLY means we can craft the JONKBOT AAAAAAAAAAAAAAAAAAAAAAA

@therealDLondon
Copy link
Member Author

Cluwn return is crazy, there should probably be a changelog entry for every event change especially Cluwn

also this FINALLY means we can craft the JONKBOT AAAAAAAAAAAAAAAAAAAAAAA

What Cluwn, those are clown spiders

@DangerRevolution

This comment was marked as resolved.

Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no immovable rod event, but I'll take it 😔

@Colin-Tel Colin-Tel merged commit e155dd6 into DeltaV-Station:master May 26, 2024
11 checks passed
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description

This PR effectively "Reworks" several of the Bionic Traits through use
of new modular TraitFunctions. These being,

**TraitPushDescription**: Ensures that an entity has the new
ExtendDescriptionComponent, then writes to said component.
ExtendDescriptionComponent serves as a new highly modular "One stop
shop" for any system wanting to add text to the shift-click examine
window. It even accepts arguments for text color, font size, and whether
or not a person must be standing within touching distance to "See" the
provided texts. It accepts arbitrarily any number of descriptions.


**TraitAddArmor**: This takes advantage of a new functionality for the
DamageableSystem, whereby entities are able to have more than one
DamageModifierSet. This allows arbitrarily any number of traits to add
as many modifier sets as desired, without fear of any compatibility
issues. These can be both negative and positive, and as Skubman has
pointed out, this can also be used to create negative traits that make a
character more vulnerable to a given damage type!

Additionally, most of the Bionics Traits have been reworked. CyberEyes
has been split into two modules, one for the base implant, and one for
the Flash Protection. Dermal Armor has been reworked using
TraitAddArmor, so that it no longer replaces your original modifier set,
and instead stacks multiplicatively with whatever your original species
modifier set was. Thus, it can now be taken by any species.

# TODO

<details><summary><h1>Media</h1></summary>
<p>

TraitPushDescription

![image](https://github.com/user-attachments/assets/4661671a-6f20-4cb1-9fad-41c36f7ad79e)

TraitAddArmor

![image](https://github.com/user-attachments/assets/bbc823e1-73bf-471d-b5f6-ef8cdf35c746)

</p>
</details>

# Changelog

:cl:
- add: Five new functions for the Trait System, AddArmor,
PushDescription, ModifyMobThresholds, AddSolutionContainer, and
ModifyStamina.
- tweak: CyberEyes Basic System has been split, now Flash Protection is
a separate module.
- add: Dermal Armor no longer replaces your original species damage
resistances. It now stacks multiplicatively with your original
resistances.
- tweak: Dermal Armor can now be taken by any species, not just Humans.
- add: Dermal Armor, and Bionic Arms can now be revealed by a close
examination. Shift click on someone within touching distance will reveal
if they have these "Obvious" cyberware.

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: Remuchi <[email protected]>
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants