Senior ID cards get a custom job name: Attempt 3 #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: YML
Signed-off-by: WarMechanic <[email protected]>
Signed-off-by: WarMechanic <[email protected]>
NullWanderer
suggested changes
Jul 22, 2024
github-actions
bot
added
S: Needs Review
Changes: Map
Changes: UI
Changes: Localization
github-actions
bot
added
Changes: Documentation
|
RSI Diff Bot; head commit 709d57d merging into 09d897e Resources/Textures/DeltaV/Decals/bricktile.rsi
|
|
i think i bunged something up, i had to pull my git files while working here in america. |
|
all the errors have been fixed, and i have playtested the solution and found everything to be working. i think its good to go |
NullWanderer
approved these changes
Aug 6, 2024
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 11, 2025
# Description Lamia don't have feet, so they instead make huge drag marks when moving through puddles. :) # Changelog :cl: - fix: Lamia now make drag marks when moving through puddles instead of regular footprints.
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Taking the Senior ID card for jobs that support it will change your job title and icon to match that of the senior role.
My advice to heads of staff: Treat your seniors like they have 60 hours of playtime. Delegate them to teach recruits properly, do things that are hard and condemn them harshly for incompetence.
Why / Balance
Fixes #1263
Technical details
This solution reverts #1218 and moves most of the job name changing logic to take place in
C.S/.../GameTicker.Spawningto catch when the player spawns both at round-start and the middle of the round. Various overrides in a few scripts check for VirtualJobName/Icon in a JobComponent.No longer uses job prototypes like in Attempt 2.
Media
https://youtu.be/_YaD1ESBiwA
Breaking changes
Changelog
🆑