Carpy the Legal Carp gets a suit for differentiation #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2024 03:27
WOOO!!!
github-actions
bot
added
Changes: YML
ghost
requested a review
from 
|
Deltanedas you're gonna love this one because it's fish |
|
RSI Diff Bot; head commit aab1fac merging into 8b138e6 Resources/Textures/DeltaV/Mobs/Pets/lawyercarp.rsi
|
|
the suit is getting multiplied by the random colour which makes it very hard to see, put it in a separate layer (similar to how it uses an unshaded layer for glowing teeth) |
deltanedas
requested changes
Jul 3, 2024
Co-authored-by: Danger Revolution! <[email protected]> Signed-off-by: Adeinitas <[email protected]>
Co-authored-by: Danger Revolution! <[email protected]> Signed-off-by: Adeinitas <[email protected]>
Add extra DamageStateVisualizer layer for Carpy
|
thanks timemaster 👍 |
|
my lord, is this funny fishe to your liking? |
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 11, 2025
…on#1456) # Description Fixed Shadow Shackles not activating when you melee hit the target. The Problem: The code checked if the target wasn't stunned when you hit someone, therefore not activating unless the target was already stunned. I fixed it by removing the ! operator on `HasComp<StunnedComponent>(target)` check. --- <details><summary><h1>Media</h1></summary> <p> https://github.com/user-attachments/assets/5ac1a5dd-5d62-4400-be64-56500c87ed5e </p> </details> --- # Changelog :cl: - fix: Fixed Shadow Shackles spell not activating.
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds a RSI for the legal carp that adds a "suit" (big grey rectangle on the sprite) and a "tie" (barely see-able based on how carp coloring works.)
Furthermore, adds functionality for "BaseUnshadedAccessory" as a layer (thanks Timemaster!!!!)
Why / Balance
Wanted something that makes Carpy visually unique so that the local greytider doesn't kill him immediately because "CARP!!"
Technical details
RSI + meta.json + one line of YAML
Media
Breaking changes
Changelog
🆑 Adeinitas, Timemaster99