New Race: IPCs #1480

Timemaster99 · 2024-07-10T21:16:30Z

About the PR

IPC race, ported over from this PR at deep. This includes the race with all old methods and conventions redone to work with our codebase.

Why / Balance

The balance information is at the linked PR, but here is a simple list. There will be some things missed here

Pros:

No lungs, immune to asphyxiation
Only takes brute and burn since they're made of metal and wires. Immune to rads and genetic
Immune to space (balanced out by power requirement below)
Cannot go into crit (balanced out by lower death threshold)
Uses both borg rechargers and APCs to charge
Special sounds, emotes, and text box
Encryption keys are installed directly into the IPC (and are removable), no headsets
Cannot be defibbed, comes with a handy reboot button
Annoying, loud beeping to alert others when battery is dead or removed
Customizable body parts (doubles as prosthetic body parts for other races)

Cons:

Medical cannot heal IPCs, as they use welders, wires, and glass to repair (if medical is the last thing standing in an emergency, they're out of luck)
No bloodstream, no chems (damage healing must be done slowly and manually with the tools mentioned above)
Lower death threshold to make up for no crit (120 damage instead of the normal 200 for other mobs)
Battery-powered, and very power hungry. IPCs get only a few minutes of charge, so they cannot operate for more than a few minutes in areas without APCs, borg rechargers, or people with extra batteries. No indefinitely floating through space, or staying put in chemistry the entire round
EMPs drain power cells
Has a maintenance panel that can be unlocked to remove encryption keys and battery. Has a long doafter, but IPCs should still be sure to lock themselves
Cannot be psionic (neither can borgs)

Technical details

Adds multiple components exclusive to IPC, including its own SharedSiliconSystem to handle this silicon-type mob. The only thing I had to nuke from the DS14 port was the FlammableComponent's atmosTransferEfficiency, since it doesn't seem to exist anymore in the component.

Media

These are videos taken from the PR at DS14, which are taken from the fork Estação Pirata.

2024-04-10_22-04-33.mp4

2024-04-10_23-28-58.mp4

2024-06-11_18-44-59.mp4

I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

add: Integrated Positronic Chassis' have joined the station workforce!

github-actions · 2024-07-10T21:17:07Z

RSI Diff Bot; head commit c268b95 merging into 913a223
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Mobs/Customization/cyberlimbs/hesphiastos/hesphiastos_alt1.rsi

State	Old	New	Status
head-1			Added
head-2			Added
head-3			Added

Resources/Textures/DeltaV/Mobs/Customization/cyberlimbs/shellguard/shellguard_alt1.rsi

State	Old	New	Status
head-1			Added
head-2			Added

Resources/Textures/DeltaV/Mobs/Customization/cyberlimbs/xion/xion_alt1.rsi

State	Old	New	Status
head-1			Added
head-2			Added

Resources/Textures/DeltaV/Mobs/Customization/cyberlimbs/xion/xion_monitor.rsi

State	Old	New	Status
head-1			Added
head-2			Added

Resources/Textures/DeltaV/Mobs/Customization/cyberlimbs/zenghu/zenghu_main.rsi

State	Old	New	Status
groin			Added
head-1			Added
head-2			Added
l_arm-1			Added
l_arm-2			Added
l_foot-1			Added
l_foot-2			Added
l_hand-1			Added
l_hand-2			Added
l_leg-1			Added
l_leg-2			Added
r_arm-1			Added
r_arm-2			Added
r_foot-1			Added
r_foot-2			Added
r_hand-1			Added
r_hand-2			Added
r_leg-1			Added
r_leg-2			Added
torso-1			Added
torso-2			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/bishop/bishop_alt1.rsi

State	Old	New	Status
head			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/bishop/bishop_main.rsi

State	Old	New	Status
head			Added
l_arm-primary			Added
l_arm-secondary			Added
l_arm-tertiary			Added
l_foot			Added
l_hand			Added
l_leg-primary			Added
l_leg-secondary			Added
r_arm-primary			Added
r_arm-secondary			Added
r_arm-tertiary			Added
r_foot			Added
r_hand			Added
r_leg-primary			Added
r_leg-secondary			Added
torso-primary			Added
torso-secondary			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/bishop/bishop_monitor.rsi

State	Old	New	Status
head-2			Added
head			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/hesphiastos/hesphiastos_main.rsi

State	Old	New	Status
l_arm-1			Added
l_arm-2			Added
l_foot-1			Added
l_foot-2			Added
l_hand-1			Added
l_hand-2			Added
l_leg-1			Added
l_leg-2			Added
r_arm-1			Added
r_arm-2			Added
r_foot-1			Added
r_foot-2			Added
r_hand-1			Added
r_hand-2			Added
r_leg-1			Added
r_leg-2			Added
torso-1			Added
torso-2			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/hesphiastos/hesphiastos_monitor.rsi

State	Old	New	Status
head-1			Added
head-2			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/morpheus/morpheus_alt1.rsi

State	Old	New	Status
head			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/morpheus/morpheus_main.rsi

State	Old	New	Status
head			Added
l_arm			Added
l_foot			Added
l_hand			Added
l_leg			Added
r_arm			Added
r_foot			Added
r_hand			Added
r_leg			Added
torso			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/shellguard/shellguard_main.rsi

State	Old	New	Status
l_arm-1			Added
l_arm-2			Added
l_foot-1			Added
l_foot-2			Added
l_hand-1			Added
l_hand-2			Added
l_leg-1			Added
l_leg-2			Added
r_arm-1			Added
r_arm-2			Added
r_foot-1			Added
r_foot-2			Added
r_hand-1			Added
r_hand-2			Added
r_leg-1			Added
r_leg-2			Added
torso-1			Added
torso-2			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/shellguard/shellguard_monitor.rsi

State	Old	New	Status
head-1			Added
head-2			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/wardtakahashi/wardtakahashi_alt1.rsi

State	Old	New	Status
head			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/wardtakahashi/wardtakahashi_main.rsi

State	Old	New	Status
head			Added
l_arm			Added
l_foot			Added
l_hand			Added
l_leg			Added
r_arm			Added
r_foot			Added
r_hand			Added
r_leg			Added
torso			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/wardtakahashi/wardtakahashi_monitor.rsi

State	Old	New	Status
head			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/xion/xion_main.rsi

State	Old	New	Status
l_arm-1			Added
l_arm-2			Added
l_foot-1			Added
l_foot-2			Added
l_hand-1			Added
l_hand-2			Added
l_leg-1			Added
l_leg-2			Added
r_arm-1			Added
r_arm-2			Added
r_foot-1			Added
r_foot-2			Added
r_hand-1			Added
r_hand-2			Added
r_leg-1			Added
r_leg-2			Added
torso-1			Added
torso-2			Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/xion/xion_monitor.rsi

State	Old	New	Status
head-1			Added
head-2			Added

Resources/Textures/SimpleStation14/Mobs/Customization/ipc_antenna.rsi

State	Old	New	Status
ipc_antenna_antlers			Added
ipc_antenna_crowned			Added
ipc_antenna_cyberhead			Added
ipc_antenna_droneeyes			Added
ipc_antenna_light			Added
ipc_antenna_lightb			Added
ipc_antenna_sidelights			Added
ipc_antenna_tesla			Added
ipc_antenna_towers			Added
ipc_antenna_tv			Added

Resources/Textures/SimpleStation14/Mobs/Customization/ipc_screens.rsi

State	Old	New	Status
ipc_screen_blank			Added
ipc_screen_blue			Added
ipc_screen_breakout			Added
ipc_screen_bsod			Added
ipc_screen_console			Added
ipc_screen_ecgwave			Added
ipc_screen_eight			Added
ipc_screen_exclaim			Added
ipc_screen_eyes			Added
ipc_screen_eyesangry			Added
ipc_screen_eyestall			Added
ipc_screen_frown			Added
ipc_screen_glider			Added
ipc_screen_goggles			Added
ipc_screen_heart			Added
ipc_screen_l			Added
ipc_screen_loading			Added
ipc_screen_monoeye			Added
ipc_screen_nature			Added
ipc_screen_orange			Added
ipc_screen_pink			Added
ipc_screen_question			Added
ipc_screen_rainbowdiag			Added
ipc_screen_rainbowhoriz			Added
ipc_screen_redtext			Added
ipc_screen_rgb			Added
ipc_screen_ring			Added
ipc_screen_scroll			Added
ipc_screen_shower			Added
ipc_screen_sinewave			Added
ipc_screen_smile			Added

Edit: diff updated after c268b95

portfiend · 2024-07-10T21:17:52Z

LFG

VMSolidus · 2024-07-10T21:27:59Z

I can at least confirm that on the DS14 playtest of these, the IPCs have had pretty much all of their known issues fixed. We're actually sufficiently satisfied with IPC, that we're probably going to be putting them on the EE repository after Saturday if nothing comes up during the next playtest.

DangerRevolution · 2024-07-10T21:48:50Z

really recommend fixing the suicide bug; IPC can kill themselves by accidentally taking out their own battery. Which instantly crits them...

Yes; only idiots would open their own panel and attempt to take shit out of them but this should be fixed to not round-remove IPC's inside maints.

Timemaster99 · 2024-07-10T22:08:01Z

really recommend fixing the suicide bug; IPC can kill themselves by accidentally taking out their own battery. Which instantly crits them...

Yes; only idiots would open their own panel and attempt to take shit out of them but this should be fixed to not round-remove IPC's inside maints.

It puts them to sleep, does not crit them. Additionally, they make a loud beeping noise when their charge is low or their battery is removed, which would likely alert anyone involved

DangerRevolution · 2024-07-10T22:13:53Z

Just editing the comment to provide more context rather than being rude;

it's up to you whether or not you fix it. It's easy to argue that it's natural selection whether or not an IPC pulls their own battery out. But this does happen on Deepstation, and Delta has lowpop hours too. This is a QOL that should be implemented if you are okay to do so; as this does impact rounds and people aren't as likely to find out-of-charge IPC's as much as you think.

Timemaster99 · 2024-07-10T23:00:29Z

Just editing the comment to provide more context rather than being rude;

it's up to you whether or not you fix it. It's easy to argue that it's natural selection whether or not an IPC pulls their own battery out. But this does happen on Deepstation, and Delta has lowpop hours too. This is a QOL that should be implemented if you are okay to do so; as this does impact rounds and people aren't as likely to find out-of-charge IPC's as much as you think.

resolved, they can no longer eject their own battery

Timemaster99 · 2024-07-15T07:14:30Z

Updated the description just a bit to reflect more features

…to ipc-port

Co-authored-by: VMSolidus <[email protected]> Signed-off-by: Timemaster99 <[email protected]>

…nent.cs Signed-off-by: VMSolidus <[email protected]>

Signed-off-by: Timemaster99 <[email protected]>

Co-authored-by: VMSolidus <[email protected]> Signed-off-by: Timemaster99 <[email protected]>

…to ipc-port

Timemaster99 · 2024-08-21T10:21:05Z

updated with VM's code review

Lyndomen · 2024-08-29T01:03:21Z

@DeltaV-Station/maintainers thoughts whenever you can, admins are chatting about it

deltanedas · 2024-08-29T01:05:24Z

Content.Server/Electrocution/ElectrocutionSystem.cs

-        return true;
-    }
+        RaiseLocalEvent(uid, new ElectrocutedEvent(uid, sourceUid, siemensCoefficient, shockDamage), true); // Parkstation-IPC
+            return true;


undo these indents

deltanedas · 2024-08-29T01:06:26Z

Content.Server/Mobs/DeathgaspComponent.cs

@@ -1,4 +1,4 @@
-using Content.Shared.Chat.Prototypes;


undo BOM change

Did these have BOM before?

look at original

deltanedas · 2024-08-29T01:07:10Z

Content.Server/Mobs/DeathgaspComponent.cs

@@ -13,6 +13,12 @@ public sealed partial class DeathgaspComponent : Component
    /// <summary>
    ///     The emote prototype to use.
    /// </summary>
-    [DataField("prototype", customTypeSerializer:typeof(PrototypeIdSerializer<EmotePrototype>))]


no reason to change this, it can be done upstream and use ProtoId too

deltanedas · 2024-08-29T01:07:30Z

Content.Server/Mobs/DeathgaspSystem.cs

@@ -1,4 +1,4 @@
-using Content.Server.Chat.Systems;


deltanedas · 2024-08-29T01:08:41Z

Content.Server/SimpleStation14/Power/Components/RandomBatteryChargeComponent.cs

+    ///     The minimum and maximum max charge the battery can have.
+    /// </summary>
+    [DataField]
+    public Vector2 BatteryMaxMinMax = new(0.85f, 1.15f);


use destruction MinMax instead of vector2

deltanedas · 2024-08-29T02:49:12Z

Content.Shared/SimpleStation14/Silicon/Systems/SharedSiliconSystem.cs

+            args.Cancelled = true;
+    }
+
+    private void OnItemSlotEjectAttempt(EntityUid uid, SiliconComponent component, ref ItemSlotEjectAttemptEvent args)


move this to a method instead of copy pasting the exact same code for each event

deltanedas · 2024-08-29T02:49:28Z

Content.Shared/SimpleStation14/Silicon/Systems/SharedSiliconSystem.cs

+    [ValidatePrototypeId<AlertPrototype>]
+    public const string ChargeAlertCategory = "BorgBattery";


this is stored on the component so use it instead

deltanedas · 2024-08-29T02:54:03Z

Content.Shared/_EstacaoPirata/DeadStartupButton/SharedDeadStartupButtonSystem.cs

+        if (!args.CanAccess || !args.CanInteract || args.Hands == null)
+            return;
+
+        if (!TryComp(uid, out MobStateComponent? mobStateComponent) || !_mobState.IsDead(uid, mobStateComponent))


dont need the trycomp

deltanedas · 2024-08-29T02:54:34Z

Content.Shared/_EstacaoPirata/DeadStartupButton/SharedDeadStartupButtonSystem.cs

+
+    private void TryStartup(EntityUid user, EntityUid target, DeadStartupButtonComponent comp)
+    {
+        if (!_net.IsServer)


no reason to not predict this

deltanedas · 2024-08-29T02:56:28Z

Content.Shared/_EstacaoPirata/EmitBuzzWhileDamaged/EmitBuzzWhileDamagedComponent.cs

+    [DataField("cycleDelay")]
+    public float CycleDelay = 2.0f;
+
+    public float AccumulatedFrametime;


ghost

Don't have much to say with this review other than what Deltanedas has already caught, but I decided to take a look at the yaml. If you can take everything into account from that, quite frankly giant review, great.

ghost · 2024-09-07T04:43:48Z

Resources/Prototypes/EstacaoPirata/Voice/speech_emotes.yml

Need to have a extra line at the end of this file if it ends at line seven because that's a standard thing for YAML...

ghost · 2024-09-07T04:49:28Z

Resources/Prototypes/EstacaoPirata/Entities/Mobs/Customization/cyberlimbs/morpheus.yml

+          color: "#FFFFFF"
+  sprites:
+  - sprite: EstacaoPirata/Mobs/Customization/cyberlimbs/morpheus/morpheus_main.rsi
+    state: r_foot


If this is the end of the file, newline.

ghost · 2024-09-07T04:49:44Z

Resources/Prototypes/EstacaoPirata/Entities/Mobs/Customization/cyberlimbs/shellguard.yml

+  - sprite: EstacaoPirata/Mobs/Customization/cyberlimbs/shellguard/shellguard_main.rsi
+    state: r_foot-1
+  - sprite: EstacaoPirata/Mobs/Customization/cyberlimbs/shellguard/shellguard_main.rsi
+    state: r_foot-2


If this is the end of the file, newline.

ghost · 2024-09-07T04:49:57Z

Resources/Prototypes/EstacaoPirata/Entities/Mobs/Customization/cyberlimbs/wardtakahashi.yml

+  speciesRestriction: [IPC] 
+  sprites:
+  - sprite: EstacaoPirata/Mobs/Customization/cyberlimbs/wardtakahashi/wardtakahashi_main.rsi
+    state: r_foot


If this is the end of the file, newline.

ghost · 2024-09-07T04:50:12Z

Resources/Prototypes/EstacaoPirata/Entities/Mobs/Customization/cyberlimbs/xion.yml

+  - sprite: EstacaoPirata/Mobs/Customization/cyberlimbs/xion/xion_main.rsi
+    state: r_foot-1
+  - sprite: EstacaoPirata/Mobs/Customization/cyberlimbs/xion/xion_main.rsi
+    state: r_foot-2


If this is the end of the file, newline.

github-actions · 2024-09-08T03:08:35Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Adeinitas <[email protected]>

ghost · 2024-09-08T04:21:32Z

MFW merging the mice accidentally caused a conflict here

Timemaster99 · 2024-09-08T04:22:59Z

MFW merging the mice accidentally caused a conflict here

causes a conflict for any species PRs, it's fine

github-actions · 2024-09-09T16:17:44Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

TadJohnson00 · 2024-09-17T13:55:57Z

Fuckin ell. Alright, here's the deal: IPCs are cool but having such a mechanically different species is a big deal. I'm gonna wait for Sam to get back from break so we can have a quick chat about this one, and see what the future looks like for synthetics as a whole

HawkeyeBlade · 2024-11-02T19:52:58Z

Timemaster pleaseeeee get IPC into the game :3

github-actions · 2024-11-15T18:09:54Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-11-15T20:13:23Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

MilonPL · 2024-11-26T10:56:18Z

Heya! Since this PR has gotten no commits or activity in the past 2 months, I'm going to close it. If you ever come back to this, feel free to open a new PR.

Day-OS and others added 5 commits July 10, 2024 02:56

Complete IPC overhaul (DeltaV-Station#31)

da48783

Missing dependencies

4a7c1c4

Updated old methods and conventions

fe305f6

Fixed IPC guidebook locale

d7bfcef

Fixed color for markings and IPC

5f0fff2

Timemaster99 requested a review from DEATHB4DEFEAT as a code owner July 10, 2024 21:16

Merge branch 'master' into ipc-port

0244121

NullWanderer self-assigned this Jul 10, 2024

NullWanderer added the S: Do Not Merge Don't merge this yet label Jul 10, 2024

IPCs can no longer eject their own battery, in congruence with borgs

dbcbfe8

Timemaster99 added 3 commits July 13, 2024 02:52

Merge branch 'master' into ipc-port

1981561

Merge branch 'master' into ipc-port

28bc046

Merge branch 'master' into ipc-port

dc9bcd3

Timemaster99 added 2 commits July 16, 2024 03:40

IPCs no longer lose charge when SSD or ghosted

d8ea098

Merge branch 'ipc-port' of https://github.com/Timemaster99/Delta-v in…

8d16f5c

…to ipc-port

Timemaster99 and others added 7 commits August 21, 2024 05:29

Fixed alert reference

5cb93ee

Apply suggestions from code review

80902f5

Co-authored-by: VMSolidus <[email protected]> Signed-off-by: Timemaster99 <[email protected]>

Update Content.Server/Power/Components/SiliconEmitSoundOnDrainedCompo…

70c3c36

…nent.cs Signed-off-by: VMSolidus <[email protected]>

Update Content.Server/Power/Components/SiliconEmitSoundOnDrainedCompo…

1140035

…nent.cs Signed-off-by: VMSolidus <[email protected]>

Added extra info on npc silicon state

4671d56

Signed-off-by: Timemaster99 <[email protected]>

Apply suggestions from code review

666ff29

Co-authored-by: VMSolidus <[email protected]> Signed-off-by: Timemaster99 <[email protected]>

Merge branch 'ipc-port' of https://github.com/Timemaster99/Delta-v in…

50284ab

…to ipc-port

deltanedas requested changes Aug 29, 2024

View reviewed changes

ghost assigned deltanedas and unassigned NullWanderer Sep 6, 2024

ghost reviewed Sep 7, 2024

View reviewed changes

github-actions bot added the S: Merge Conflict Fix your PR! label Sep 8, 2024

Merge branch 'master' into ipc-port

c268b95

Signed-off-by: Adeinitas <[email protected]>

github-actions bot removed the S: Merge Conflict Fix your PR! label Sep 8, 2024

github-actions bot added the S: Merge Conflict Fix your PR! label Sep 9, 2024

deltanedas removed the Status: Merge Conflict label Nov 15, 2024

github-actions bot added the Status: Merge Conflict label Nov 15, 2024

deltanedas removed the Status: Merge Conflict label Nov 20, 2024

MilonPL closed this Nov 26, 2024

		[ValidatePrototypeId<AlertPrototype>]
		public const string ChargeAlertCategory = "BorgBattery";

New Race: IPCs #1480

New Race: IPCs #1480

Conversation

Timemaster99 commented Jul 10, 2024 • edited Loading

About the PR

Why / Balance

Technical details

Media

Breaking changes

github-actions bot commented Jul 10, 2024 • edited Loading

portfiend commented Jul 10, 2024

VMSolidus commented Jul 10, 2024

DangerRevolution commented Jul 10, 2024

Timemaster99 commented Jul 10, 2024

DangerRevolution commented Jul 10, 2024 • edited Loading

Timemaster99 commented Jul 10, 2024

Timemaster99 commented Jul 15, 2024

Timemaster99 commented Aug 21, 2024

Lyndomen commented Aug 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost left a comment • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 8, 2024

ghost commented Sep 8, 2024

Timemaster99 commented Sep 8, 2024

github-actions bot commented Sep 9, 2024

TadJohnson00 commented Sep 17, 2024

HawkeyeBlade commented Nov 2, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

MilonPL commented Nov 26, 2024

Timemaster99 commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

DangerRevolution commented Jul 10, 2024 •

edited

Loading

ghost left a comment •

edited by ghost

Loading