Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rodentia Species #1511

Merged
69 commits merged into from
Sep 8, 2024
Merged

Rodentia Species #1511

69 commits merged into from
Sep 8, 2024

Conversation

portfiend
Copy link
Contributor

@portfiend portfiend commented Jul 19, 2024

About the PR

adds Rodentia, a new species of anthropomorphic rodents (with some non-rodent-but-still-adjacent marking options).

Why / Balance

rodents, rabbits, bats, possums are all species that are currently not covered by our customization system but have some level of demand to them. i made sure to give this species a lot of options customization-wise to cover all of these bases. however, someone else mentioned on Discord that bats should probably also be their own species too (these rodentia "bats" are wingless) and i generally agree with that sentiment

Technical details

Rodentia's rummage produces garbage like 70% of the time and edible food the remaining 30%. This food is either a single wedge of cheese (not a wheel), a snack, or (rarely) a single-serving meal. Keep in mind that rummaging is one-time per disposal chute once per disposal bin on a cooldown - not per-rodentia - so each chute on the station can only be rummaged once every 5 minutes. This combined with competition with other hungry rodentia and limited access means that rodentia are unlikely to produce lots of food. I can still adjust the numbers though

mouth storage ability grants the following:

  • a 2x2 storage in their mouth, which cannot store sharp objects or animals
  • being pushed, attacked for more than 2 damage, or knocked over spits out the items
  • other people can tell if the rodentia has something in their mouth
  • they cannot eat or speak intelligibly if something is in their mouth

the name scheme of Rodentia is "Last First", where Last is a descriptor (strong, big-eyed, trash-eating) and First is either a) a pet name (nibbles, peanut) b) a simple "first name" (monty, basil), or c) what sounds like the name of an english furry-themed town (Squeakson)

Media

Screenshot_149
Screenshot_147

Screenshot_144 Screenshot_143 Screenshot_142 Screenshot_141

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Rummage action on disposal chutes is now bound to the Rummager component rather than the RatKing component. If you want to give an entity the ability to rummage through trash, give them "Rummager"

RatKingRummageable objects now use a 5-minute cooldown instead of a one-time "Looted" flag. setting RatKingRummageable.Looted = true will still disable the object from further rummaging, but now when the object is looted the RatKingRummageable.LastLooted property is set instead

adds a new Naming scheme type, LastFirst, which is added to the switch statement in NamingSystem.cs

mousetraps can now be always activated with a new component, AlwaysTriggerMousetrapComponent

Changelog

🆑 portfiend

  • add: Added Rodentia, a new species of playable rodent-like humanoids.
  • tweak: Mobs that are capable of rummaging (such as the new Rodentia species) can do so every five minutes. They will find small snacks in trash bins instead of entire wheels of cheese.

Other Notes

if you're from another server, yes you can port this

most of the discussion on this species is taking place on the DV suggestions forum in the discord but i will read replies here too

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Documentation Changes any xml or md files Changes: Sprite Changes any png or json in an rsi labels Jul 19, 2024
Copy link
Contributor

github-actions bot commented Jul 19, 2024

RSI Diff Bot; head commit a52759a merging into b420936
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Effects/creampie.rsi

State Old New Status
creampie_rodentia Added

Resources/Textures/DeltaV/Effects/speech.rsi

State Old New Status
rodentia0 Added
rodentia1 Added
rodentia2 Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/body_markings.rsi

State Old New Status
countershade Added
countershade_f Added
countershade_lleg Added
countershade_rleg Added
fawn Added
hooded Added
hooded_f Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/cheek_markings.rsi

State Old New Status
cheeks Added
cheeks_overlay Added
fluff Added
fluff_alt Added
fluff_alt_overlay Added
fluff_overlay Added
whiskers Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/ear_markings.rsi

State Old New Status
bat Added
bat_large Added
hamster Added
hamster_overlay Added
long Added
long_overlay Added
mouse Added
mouse_large Added
mouse_large_overlay Added
mouse_overlay Added
none Added
pointy Added
rabbit Added
rabbit_overlay Added
small Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/head_markings.rsi

State Old New Status
blaze Added
round Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/snout_markings.rsi

State Old New Status
bat Added
bat_nose Added
bat_overlay Added
flat Added
flat_nose Added
flat_overlay Added
round Added
round_nose Added
round_overlay Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/tail_markings.rsi

State Old New Status
beaver Added
hamster Added
long Added
long_overlay Added
long_tip Added
mouse Added
rabbit Added
rabbit_overlay Added
short Added
squirrel Added
squirrel_overlay Added

Resources/Textures/DeltaV/Mobs/Species/Rodentia/parts.rsi

State Old New Status
full Added
head_f Added
head_m Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso_f Added
torso_m Added

Edit: diff updated after a52759a

@portfiend portfiend marked this pull request as ready for review July 19, 2024 21:23
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let Deltanedas or someone decide on if they want this/features of this or whatever, but the code looks fine.

Resources/Locale/en-US/deltav/markings/rodentia.ftl Outdated Show resolved Hide resolved
@portfiend
Copy link
Contributor Author

ready for merge when maintainers approve it

@portfiend portfiend requested a review from deltanedas August 28, 2024 03:29
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good now but needs lyndos approval too

@deltanedas deltanedas requested a review from Lyndomen August 29, 2024 00:54
@Lyndomen
Copy link
Contributor

ill get back to you in 3 business days

@Verbalase
Copy link

ill get back to you in 3 business days

what did bro really mean by this

Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

game director approved

@ghost
Copy link

ghost commented Sep 8, 2024

ill get back to you in 3 business days

what did bro really mean by this

watch this you goober!!

@ghost ghost merged commit 690cbe9 into DeltaV-Station:master Sep 8, 2024
15 checks passed
@ghost
Copy link

ghost commented Sep 8, 2024

THE MICE ARE COMING!!

@jimmy12or
Copy link
Contributor

Yay I can make my bun!

@portfiend
Copy link
Contributor Author

portfiend commented Sep 10, 2024

hi also when i wrote "forks are free to port and use this" i really did mean it, which is to say if merely me giving the word is enough to will it into reality then the additions and code enclosed in this PR are licensed under the MIT license thanks

sleepyyapril added a commit to Grimbly-Station/Grimbly-Station that referenced this pull request Sep 17, 2024
<!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
<!-- The text between the arrows are comments - they will not be visible
on your PR. -->

## About the PR
<!-- What did you change in this PR? -->
Ported over Rodentia from Delta-V. 


## Why / Balance
<!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
I wanted to play as my bnuy :)
see the original rodentia PR for Delta-V
DeltaV-Station/Delta-v#1511 (comment)

## Technical details
<!-- If this is a code change, summarize at high level how your new code
works. This makes it easier to review. -->
Mostly copy-pasted from Delta-V with some changes to make them fit in
with grimbly. The changes are:

- they can crawl at their sneaking speed. this is to replace sneaking
once everyone can crawl under tables.

- they can speak mouse

- they can be super small due to height slider. however if you go that
small mouse traps will just kill you instantly

- they take 30% more brute instead of just blunt, because sneak
shenanigans

- they now bite instead of scratch, and their bite does a bonus 1
structural damage. Meaning they can now chew through windows and doors
(it takes 500 rat bites to eat through an airlock)
## Media
<!-- 
PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
Small fixes/refactors are exempt.
Any media may be used in SS14 progress reports, with clear credit given.

If you're unsure whether your PR will require media, ask a maintainer.
-->

![image](https://github.com/user-attachments/assets/8c272487-ab02-43f4-9427-63cd0ca0cca5)

## Requirements
<!-- 
Due to influx of PR's we require to ensure that PR's are following the
correct guidelines.

Please take a moment to read these if its your first time.

Check the boxes below to confirm that you have in fact seen these (put
an X in the brackets, like [X]):
-->
- [ x ] I have read and I am following the [Pull Request
Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
I understand that not doing so may get my pr closed at maintainer’s
discretion
- [ x ] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase

## Breaking changes
<!--
List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
-->
Same as the original PR, no further files were touched

**Changelog**
<!--
Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
-->

<!--
Make sure to take this Changelog template out of the comment block in
order for it to show up. Changelog must have a 🆑 symbol, so the bot
recognizes the changes and adds them to the game's changelog. -->
🆑
- add: Ported Rodentia from Delta-V. See
DeltaV-Station/Delta-v#1511 (comment)
- tweak: Rodentia take 30% more brute
- tweak: Rodentia crawl 4x faster (this is so when crawling goes under
tables, the sneak button will grt removed)
- tweak: rodentia can be even smaller than harpies and felinids.
However, mouse traps scale their damage off your size and will just
instantly kill you if you do this. Shoes will not save you
- removed: My sanity
@paige404 paige404 mentioned this pull request Dec 18, 2024
2 tasks
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 13, 2025
Got hit by the anticheat and saw this

Signed-off-by: DEATHB4DEFEAT <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants