Better glasses for arachnids & moths #1555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Badda bing badda boom. Sprites and meta files changes yay.
Not sure if this mattered at all, but oh well.
github-actions
bot
added
Changes: YML
|
RSI Diff Bot; head commit 8d483bf merging into bdb29b5 Resources/Textures/Clothing/Head/Hardsuits/salvage.rsi
Resources/Textures/Clothing/Eyes/Glasses/gar.rsi
Resources/Textures/Clothing/Eyes/Glasses/glasses.rsi
Resources/Textures/Clothing/Eyes/Glasses/jamjar.rsi
Resources/Textures/Clothing/Eyes/Glasses/jensen.rsi
Resources/Textures/Clothing/Eyes/Glasses/mercglasses.rsi
Resources/Textures/Clothing/Eyes/Glasses/meson.rsi
Resources/Textures/Clothing/Eyes/Glasses/ninjavisor.rsi
Resources/Textures/Clothing/Eyes/Glasses/outlawglasses.rsi
Resources/Textures/Clothing/Eyes/Glasses/science.rsi
Resources/Textures/Clothing/Eyes/Glasses/secglasses.rsi
Resources/Textures/Clothing/Eyes/Glasses/sunglasses.rsi
Resources/Textures/Clothing/Eyes/Glasses/thermal.rsi
Resources/Textures/Clothing/Eyes/Hud/beergoggles.rsi
Resources/Textures/Clothing/Eyes/Hud/beerpatch.rsi
Resources/Textures/Clothing/Eyes/Hud/diag.rsi
Resources/Textures/Clothing/Eyes/Hud/diagpatch.rsi
Resources/Textures/Clothing/Eyes/Hud/friedonion.rsi
Resources/Textures/Clothing/Eyes/Hud/med.rsi
Resources/Textures/Clothing/Eyes/Hud/medonion.rsi
Resources/Textures/Clothing/Eyes/Hud/medonionbeer.rsi
Resources/Textures/Clothing/Eyes/Hud/medpatch.rsi
Resources/Textures/Clothing/Eyes/Hud/medsec.rsi
Resources/Textures/Clothing/Eyes/Hud/medsecengi.rsi
Resources/Textures/Clothing/Eyes/Hud/omni.rsi
Resources/Textures/Clothing/Eyes/Hud/onionbeer.rsi
Resources/Textures/Clothing/Eyes/Hud/sec.rsi
Resources/Textures/Clothing/Eyes/Hud/secpatch.rsi
Resources/Textures/Clothing/Eyes/Hud/synd.rsi
Resources/Textures/Clothing/Eyes/Hud/syndagent.rsi
Resources/Textures/Clothing/Eyes/Misc/blindfold.rsi
Resources/Textures/Clothing/Eyes/Misc/eyepatch.rsi
Resources/Textures/DeltaV/Clothing/Eyes/Glasses/safetyglasses.rsi
Resources/Textures/DeltaV/Clothing/Eyes/Hud/prescmedhud.rsi
Resources/Textures/DeltaV/Clothing/Eyes/Hud/prescsechud.rsi
|
Colin-Tel
reviewed
Jul 31, 2024
I moved the `type: Inventory` lines back to their original spot and added the `speciesID` line under them.
Made a mistake, oopsies
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Merging with the upstream
|
Converting this into a daft for now, i've decided I'm gonna actually sprite all of the glasses and huds now and get it done in one pr instead of multiple. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Adds sprites and glasses from items only only admins can spawn in.
DangerRevolution
suggested changes
Aug 20, 2024
There was a problem hiding this comment.
I gotta lot of stuff to remove tbh.
Work on this PR will probably slow down a lot because I'm packing my stuff up to move.
|
Okay well, with my current experience level in github I can not fix this PR. If I try and learn like I have been, I will lose motivation for this little project and it'll never get merged. So, I'm just opening a new PR that doesn't have anything fucked up in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
I added species sprites to most of the glasses and huds ingame for moths and arachnids, including the blindfold and eyepatch. I added in hand sprites for the beer goggles and medsec hud. I also added 1 pixel that was missing on the vulpkanin salvage hardsuit helmet.
Why / Balance
I think it makes the glasses look a lot better on arachnids and moths and will make players more inclined to wear them while playing those species. I felt the in hand sprites just made sense to add. For the vulp salv hardsuit, there was 1 pixal missing between you turning the light off and on and that bothered me.
Technical details
speciesId: arachnidandspeciesId: mothwere both added undertype: Inventoryfor both the player versions and dummy versions of these species. Most glasses and huds now have image files labelledequipped-EYES-arachnidandequipped-EYES-mothand are referred to in the meta.json files so the game knows to use those sprites for these species.Media
Breaking changes
Changelog
It's just sprite changes, I don't think it needs one.