Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(W.I.P) Lead, Lead Lined Crates, Lead Weaponry #1558

Conversation

Reene-Ramos
Copy link

@Reene-Ramos Reene-Ramos commented Jul 30, 2024

About the PR

Adds Lead Ore (Crabs), Lead Ingots, Lead Lined Crates, Lead Spears, and Lead Ammunition [This part is subject to change]

Why / Balance

This adds a container that can be used to safely transport hazardous materials, such as Bananium.

Technical details

New code adds: Lead spawning in asteroids
Not coded yet: Lead Ore Crabs, Lead Ore, Lead Ingots, Lead Crate

Media

Will add media once I do the sprites.

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

P.S. Coding will be slow, as I have to actually find what I need to code in the files first

Adds the code making it so that Lead can spawn in asteroids
@github-actions github-actions bot added the Changes: YML Changes any yml files label Jul 30, 2024
Reene-Ramos and others added 3 commits August 13, 2024 05:08
@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an rsi label Aug 13, 2024
Copy link
Contributor

github-actions bot commented Aug 13, 2024

RSI Diff Bot; head commit 42d3f7c merging into 8088aef
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Materials/ingots.rsi

State Old New Status
lead_1 Added
lead_2 Added
lead_3 Added

Resources/Textures/Objects/Weapons/Melee/lead_spear.rsi

State Old New Status
equipped-BACKPACK Added
equipped-SUITSTORAGE Added
inhand-left Added
inhand-right Added
spear Added
spear1 Added
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/Structures/Storage/Crates/lead_lined.rsi

State Old New Status
base Added
closed Added
icon Added
open Added
sparking Added
welded Added

Edit: diff updated after 42d3f7c

@Reene-Ramos Reene-Ramos changed the title (W.I.P) Lead & Lead Lined Crates (W.I.P) Lead, Lead Lined Crates, Lead Weaponry Aug 13, 2024
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Aug 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Samsterious
Copy link
Contributor

I question whether adding this much content is actually justified solely by one key item. I think it would be much more reasonable to write a PR adding a hazmat container that has to be ordered from Logi, like artifact containers.

@deltanedas
Copy link
Member

artifact containers already block radiation

@Samsterious
Copy link
Contributor

This is true, although the catch is that they can only hold one stack of items. A crate variant dedicated specifically to hazmat would serve a function distinct from that. Regardless, I think this PR lacks the mechanical substance to justify an entire new ore material.

@TadJohnson00
Copy link
Contributor

Agreed. Besides, I don't think @Reene-Ramos is still working on this.

@TadJohnson00
Copy link
Contributor

Closing this PR due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Merge Conflict Fix your PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants