-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(W.I.P) Lead, Lead Lined Crates, Lead Weaponry #1558
(W.I.P) Lead, Lead Lined Crates, Lead Weaponry #1558
Conversation
Adds the code making it so that Lead can spawn in asteroids
All sprites were done by Zwei. Co-Authored-By: ZweiHawke <[email protected]>
RSI Diff Bot; head commit 42d3f7c merging into 8088aef Resources/Textures/Objects/Materials/ingots.rsi
Resources/Textures/Objects/Weapons/Melee/lead_spear.rsi
Resources/Textures/Structures/Storage/Crates/lead_lined.rsi
|
Might have errors, if spotted, please notify me on discord.
…://github.com/Reene-Ramos/Reenes-likely-awful-code into Lead,-lead-lined-crates-lead-weaponry
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I question whether adding this much content is actually justified solely by one key item. I think it would be much more reasonable to write a PR adding a hazmat container that has to be ordered from Logi, like artifact containers. |
artifact containers already block radiation |
This is true, although the catch is that they can only hold one stack of items. A crate variant dedicated specifically to hazmat would serve a function distinct from that. Regardless, I think this PR lacks the mechanical substance to justify an entire new ore material. |
Agreed. Besides, I don't think @Reene-Ramos is still working on this. |
Closing this PR due to inactivity. |
About the PR
Adds Lead Ore (Crabs), Lead Ingots, Lead Lined Crates, Lead Spears, and Lead Ammunition [This part is subject to change]
Why / Balance
This adds a container that can be used to safely transport hazardous materials, such as Bananium.
Technical details
New code adds: Lead spawning in asteroids
Not coded yet: Lead Ore Crabs, Lead Ore, Lead Ingots, Lead Crate
Media
Will add media once I do the sprites.
Breaking changes
Changelog
P.S. Coding will be slow, as I have to actually find what I need to code in the files first