Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Pharmacist #1576

Open
wants to merge 112 commits into
base: master
Choose a base branch
from
Open

Conversation

Bribrooo
Copy link
Contributor

@Bribrooo Bribrooo commented Aug 3, 2024

About the PR

Adds the Pharmacist role, a chemist who focuses on roleplay interactions, RP-meds, and others.
Works with the psychologist, chemists, or independently.
Has access to Chemistry and Psychologist.
Adds news access Pharmacist. Requires to have played 24h as Chemist.

Why / Balance

With the addition of more and more reagents, the chemists are often overwhelmed with requests, adding this role not only encourages chemistry players to finally become social (totally not like me), but can also prescribe the RP medication without approval of the CMO, still requiring it for any other reagent.

Spawn point, role, inventory, signs, description, icon, access, airlocks, closet, and stamp were already made and tested successfully.

It can probably be mapped independently or in station medical outposts since it is its own booth.

TO DO

  • More drip options
  • Discrete belt chem bag
  • Pharmacy prescription paper to fix
  • SoP regulations
  • Guidebook entries
    • Pharmacist
    • Chemicals/Medicine

Reagents to do

  • Asparatine - mild painkiller
    • Sodium Salicylate
      • Methyl Salicylate
        • Salicylic Acid
          • Sodium Phenolate (used for carbonylation)
            • Benzenesulfonic Acid (used for endothermic reaction)
        • Methanol
    • Acetyl Chloride
      • Acetic Anhydride
      • Hydrogen Chloride
      • (Hydrochloric Acid - made when Hydrogen Chlorine enters in contact with water.)
    • Acetic Acid - used to make more acetic anhydride (methanol + acetic acid (+ sulfuric acid) = acetic anhydride)
  • Vicodillicaine - strong headache med, hallucinogen
  • Zepprocane - barbiturate, used as anxiolytic and anticonvulsant
    • Barbituric Acid - an acidic reagent, reacts with artifacts
      • Hydrogen Iodide - light molecule often used in pharmaceutics and barbituric acid reaction
      • Sodium amalgam - from an exothermic reaction causing an alloy made of mercury and sodium which happens
        naturally when they're pressed together. causes no damage (0.0001 x 15 dmg)
  • Cordivol - "α1- + β-selective" α1 antagonist, non-selective: β1 + β2 antagonist
    • Propylene glycol - used in foods
      • Propylene oxide - flammable
      • Aryloxypropanolamine - a precursor to most β-blockers
        • Catechol - from catechin, but not here though
          • Hydrogen Peroxide - oxidizing agent
        • Epichlorohydrin - synthesis-related molecule
          • Allyl Chloride - used to be an antiseptic
  • Naguuprofen - mild headache med, normally used to combat hangovers. isobutylphenylethanol is mixed with carbon and oxygen alongside hydrogen chlorine, with iron acting as a catalyst
    • Isobutylphenylethanol - from the former and hydrogen
      • Isobutylacetophenone - from a mix of the two former
        • Isobutylbenzene - from toluene and propene, with a sodium-potassium catalyst
        • Hydrogen Fluoride - hydrogen and fluorine with heat applied
          • Tuolene - mix of benzene and methanol, using sulfuric acid as a catalyst
          • Propene - from acetone, charcoal, and some heat
Abandonned/Scrapped Dawcicadone - cholinesterase inhibitors and glutamate regulators? memory loss. Vanlicylicane - Mild leg pain painkiller. Grahatrocine - light painkiller for shoulder pain. Scotycoine - mild painkiller for stomach pain.

Media

image
image
image
image
https://github.com/user-attachments/assets/f99adbf1-8a04-418a-b5a3-3430ee373384

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

  • add: A new employee arrives at the station... it's the Pharmacist!
  • add: A whole new plethora of pharmaceutical reagents and their predecessors!

Bribrooo and others added 6 commits August 2, 2024 17:35
Adds vicodilicaine, genesis of the pharmacology...
Moves the _CD folder to DeltaV folder as commit 336ae81 requested, also to avoid confusion
Adds Zepprocane, Barbituric Acid, Sodium Amalgam, Hydrogen Iodide, and future chem for Asparatine
Adds a lab coat and a suit for the pharmacist.
Adds Asparatin, at least its effects (thx for the help solidus YES IM TAGGING YOU I WAS DESPERATE)

Co-Authored-By: VMSolidus <[email protected]>
muahahaha it works muahahaha
@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Documentation Changes any xml or md files Changes: Sprite Changes any png or json in an rsi labels Aug 3, 2024
Copy link
Contributor

github-actions bot commented Aug 3, 2024

RSI Diff Bot; head commit a9700ab merging into 7add23d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/OuterClothing/Coats/labcoat_pharmacist.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon-open Added
icon Added
inhand-left Added
inhand-right Added
open-equipped-OUTERCLOTHING Added
open-inhand-left Added
open-inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/pharmacist.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/pharmacist.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/pharmacistshirt.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Interface/Misc/job_icons.rsi

State Old New Status
Pharmacist Added

Resources/Textures/DeltaV/Markers/jobs.rsi

State Old New Status
pharmacist Added

Resources/Textures/DeltaV/Objects/Devices/pda.rsi

State Old New Status
pda-pharmacist Added

Resources/Textures/DeltaV/Objects/Misc/id_cards.rsi

State Old New Status
idpharmacist Added

Resources/Textures/DeltaV/Objects/Misc/stamps.rsi

State Old New Status
stamp-pharmacist Added

Resources/Textures/DeltaV/Objects/Specific/Chemistry/chem_bag_pharmacist.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Structures/Wallmounts/signs.rsi

State Old New Status
direction_pharmacy Added

Resources/Textures/Objects/Misc/bureaucracy.rsi

State Old New Status
paper_stamp-pharmacist Added

Resources/Textures/Structures/Storage/closet.rsi

State Old New Status
pharmacy_door Added

Edit: diff updated after a9700ab

@Bribrooo
Copy link
Contributor Author

Bribrooo commented Aug 3, 2024

Add any name, recipe, and effects of rp medications you'd like to see in-game for your character(s) or general use!

@Avalon-Proto
Copy link
Contributor

I hope you don't plan to stick them in the same room as the chemists. As that can get rather crowded already

@Bribrooo
Copy link
Contributor Author

Bribrooo commented Aug 3, 2024

READ WHAT I WROTE

@Avalon-Proto
Copy link
Contributor

... Forget I said anything. Jedi mindtrick bullshittery. I missed that last section :blunt:

@IamVelcroboy
Copy link
Member

I just skimmed this and I noticed the prescriptions, something I've wanted to add for a long time. I think it would be a massive RP booster for medical/chem/patients.

Wondering if we need to give doctors stamps, or a stamp function in their PDA, or even a stamp they can eject from the PDA. Something to verify a script that the patient can take to the pharmacy to get filled and it's probably not a forgery

@DangerRevolution
Copy link
Contributor

shouldn't the reagents be in a seperate PR?

@Bribrooo
Copy link
Contributor Author

Bribrooo commented Aug 4, 2024

I wouldn't add the reagents only for roleplay to put more pressure on the chemists. That's why I didn't choose to put the reagents in another PR.

@Timemaster99
Copy link
Contributor

The outfit looks far too similar to the senior physician, and with its current relation to medical, will cause player confusion. Adding a new trim color to the white coat could be a better option.

I'll also bring attention to the major issue, which is how similar this role is to Chemist. Roles for the game need to be designed in a way that is easy to understand at a glance, because the description strings and PR text will almost never be read by a majority of players. I don't see anything in the PR that would stop the chemist from doing their job, or would stop the pharmacist from being an extra chemist. In the current state, I can see Pharmacist acting as a chemist in med for a majority of the shift, because med outposts are lonely and the chemists will likely have many of the component compounds of the RP meds already made.

I do think there are some solutions to this, both of which can be implemented together.
First would be to implement the smartfridge from ss13, which could create a sort of storefront design for over-the-counter medications, and then add a pharmacist access to it. From there, the pharmacist could be represented in a way that's more akin to a store-keep, and stock the medications of people who come to visit.
The second solution is to add symptoms in-game, either randomly-acquired or chosen as a trait (similar to the old runny nose trait). These would be harmless, or perhaps inflict meaningless damage, which would give more players reasons to roleplay sickness and visit the pharmacy for their symptoms. Perhaps, they'll even stock up for future symptoms if they choose to have migraines as a trait.

Aside from these issues, I do enjoy the role and the RP it could present. Perhaps doctors and psychologists can gain access to these prescription papers to write them for patients, pending pharmacist approval

@Colin-Tel
Copy link
Contributor

Personally, I don't really see why'd you add a pharmacist when you could just add another chemist to a station.

@Bribrooo
Copy link
Contributor Author

Bribrooo commented Aug 5, 2024

The outfit looks far too similar to the senior physician, and with its current relation to medical, will cause player confusion. Adding a new trim color to the white coat could be a better option.

I tried to toy with colors unsuccessfully, I'm still toying with it but it's more placeholder colors than anything for now

I can see Pharmacist acting as a chemist in med for a majority of the shift, because med outposts are lonely and the chemists will likely have many of the component compounds of the RP meds already made.

I'm introducing new side reagents that will take a long process to make a decent amount or obtain them simply. Also, a lot of those rp reagents will be designed to be a pain in the ass to make to either test your chemistry skills or so that it can simply feel high standards since pharmacology is an unforgiving sector of medicine (trust me on this one).

From there, the pharmacist could be represented in a way that's more akin to a store-keep, and stock the medications of people who come to visit.

That's what I'm trying to do; by making them separate from the main medical wing, like the psychiatrist, so they are their own booth that they can run independently, ready to help people with questions about health, or hand out their prescriptions.

Personally, I don't really see why'd you add a pharmacist when you could just add another chemist to a station.

I feel like adding another chemist to the station wouldn't add the more in-depth roleplay people could have, by having a person whose purpose is to get them their medication, and possibly also hook them up with a psychologist (which is deserted most of the time)

modified the colors from light blue to light green
changed the light blue to light green
added discrete pharmacist chem bag + fixed pharmacistshirt.rsi
@Catanautical
Copy link

I feel like adding another chemist to the station wouldn't add the more in-depth roleplay people could have, by having a person whose purpose is to get them their medication, and possibly also hook them up with a psychologist (which is deserted most of the time)

I do very agree with the fact that the pharmacist should be the linking factor of roleplay between the chemists, the psychiatrist, and medical, but it could also include being called a dispensary for perscription drugs such as cannabis and tobacco, and also work with the new Interdyne chemists you see occasionally to get more legal-skirting drugs. This way all of these become options that the pharmacy/dispensary can be involved in. All of this stuff needs to be webbed in to have as much interaction with the crew on the station as possible during their job, that way it's actually fulfilling to play and enjoyable to the rest of the crew. But, this is all my two-cents.

Personally, I don't really see why'd you add a pharmacist when you could just add another chemist to a station.

And the problem here with adding 'just another chemist' is because they're literally 'JUST ANOTHER CHEMIST'. A chemist has no obligation to interact with any crew whatsoever, and if you just add another chemist, they will just complain that the other chemists have already made all the medical drugs and have nothing to do, since it is almost entirely the chemist culture to only focus on medbay and that's it. We're trying to create a job similar in nature that does not have obligation to dispense to medbay other than the psychologist and/or psyciatrist so that they can focus on the rest of the crew's drug use.

Adds Asparatine, Sodium Salicylate, Acetyl Chloride, Acetic Acid, Methyl Salicylate, Salicylic Acid, Methanol,  Sodium Phenolate, Benzenesulforic Acid, Acetic Anhydride, Hydrogen Chloride and Hydrochloric Acid
@Bribrooo Bribrooo requested review from IamVelcroboy and a team as code owners November 22, 2024 08:59
@github-actions github-actions bot added the Changes: Audio Changes any audio files label Nov 22, 2024
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Nov 22, 2024
@Bribrooo
Copy link
Contributor Author

god strike me down because i am done

@Bribrooo
Copy link
Contributor Author

Actually I'm going to make the prescription paper a custom thing. . .

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Nov 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/L 256-1023 lines and removed S: Merge Conflict Fix your PR! labels Nov 29, 2024
Copy link
Contributor

github-actions bot commented Dec 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Dec 1, 2024
@Bribrooo
Copy link
Contributor Author

Bribrooo commented Dec 8, 2024

nvm about the prescription thing... I'll add it later when I actually know what the hell I'm doing

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Dec 8, 2024
@Bribrooo Bribrooo requested a review from Samsterious December 8, 2024 00:39
Signed-off-by: BriBrooo <[email protected]>
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Dec 15, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Merge Conflict Fix your PR! S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.