Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aPDA Resprite #1588

Merged
merged 6 commits into from
Aug 9, 2024
Merged

aPDA Resprite #1588

merged 6 commits into from
Aug 9, 2024

Conversation

ZweiHawke
Copy link
Contributor

@ZweiHawke ZweiHawke commented Aug 8, 2024

About the PR

Changed the PDA sprite to be a new, more robust sprite.

Why / Balance

With the addition of cosmetic roles, and the associated appearances in-between; this would give every cosmetic and existing role a new visual identity and improve readability of the PDA. This is also foundational for aPDA, a larger PDA rework that provided everything works out, will be delivered in chunks.

Technical details

The .meta inside Delta's PDA now covers all types of PDA appearances.
Modified PDA base Scale to 0.75, 0.75

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
    image
    image
    image

Breaking changes

Added new filepaths:

"name": "pda-admin"
"name": "pda-baker"
"name": "pda-butcher"
"name": "pda-deckworker"
"name": "pda-electrician"
"name": "pda-excavator"
"name": "pda-fool"
"name": "pda-freelancer"
"name": "pda-jester"
"name": "pda-inventoryassociate"
"name": "pda-labsci"
"name": "pda-lifesupporttech"
"name": "pda-mantis"
"name": "pda-mixologist"
"name": "pda-musician"
"name": "pda-offduty"
"name": "pda-phys"
"name": "pda-pizzaiolo"
"name": "pda-plasmatech"
"name": "pda-practicingnurse"
"name": "pda-prisonguard"
"name": "pda-prospector"
"name": "pda-resident"
"name": "pda-student"
"name": "pda-tourist"
"name": "pda-visitor"
"name": "pda-xenobio"
Moved existing filepaths of the PDA to DeltaV's path.

Changelog

  • add: Added 85 new PDA sprites

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

RSI Diff Bot; head commit 26ec519 merging into 2db0e03
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Devices/pda.rsi

State Old New Status
equipped-BELT Modified
id_overlay Modified
insert_overlay Modified
light_overlay Modified
pda-chaplain Modified
pda-chiefjustice Modified
pda-clerk Modified
pda-corpsman Modified
pda-mailcarrier Modified
pda-martialartist Modified
pda-prosecutor Modified
inhand-left Added
inhand-right Added
pda-admin Added
pda-atmos Added
pda-baker Added
pda-bartender Added
pda-boxer Added
pda-brigmedic Added
pda-butcher Added
pda-captain Added
pda-cargo Added
pda-ce Added
pda-centcom Added
pda-chemistry Added
pda-clear Added
pda-clown Added
pda-cluwne Added
pda-cmo Added
pda-cook Added
pda-deckworker Added
pda-detective Added
pda-electrician Added
pda-engineer Added
pda-ert Added
pda-excavator Added
pda-fool Added
pda-freelancer Added
pda-genetics Added
pda-hop Added
pda-hos Added
pda-hydro Added
pda-interncadet Added
pda-internmed Added
pda-internsci Added
pda-internservice Added
pda-interntech Added
pda-inventoryassociate Added
pda-janitor Added
pda-jester Added
pda-labsci Added
pda-lawyer Added
pda-library Added
pda-lifesupporttech Added
pda-mantis Added
pda-mechanic Added
pda-medical Added
pda-mime Added
pda-miner Added
pda-mixologist Added
pda-musician Added
pda-offduty Added
pda-paramedic Added
pda-phys Added
pda-pirate Added
pda-pizzaiolo Added
pda-plasmatech Added
pda-practicingnurse Added
pda-prisonguard Added
pda-prospector Added
pda-qm Added
pda-rd Added
pda-reporter Added
pda-resident Added
pda-roboticist Added
pda-science Added
pda-security Added
pda-seniorengineer Added
pda-seniorofficer Added
pda-seniorphysician Added
pda-seniorresearcher Added
pda-student Added
pda-syndi-agent Added
pda-syndi Added
pda-tourist Added
pda-virology Added
pda-visitor Added
pda-warden Added
pda-xenobio Added
pda-zookeeper Added
pda Added

Edit: diff updated after 26ec519

@Colin-Tel Colin-Tel self-requested a review August 8, 2024 23:05
# DeltaV aPDA Resprite PDA Size change, makes it smaller for the full detail.
@ZweiHawke ZweiHawke marked this pull request as ready for review August 9, 2024 05:06
@Colin-Tel
Copy link
Contributor

image

Try to be concise with changelogs; this PR could just be one - add: line instead of 3 separate ones.

@ZweiHawke
Copy link
Contributor Author

Will do! Let me change that now.

Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as how they appear in-game: awesome, and I think it's ready-to-go.

As far as the overall implementation, if you're making adjustments to DeltaV files, you actually don't need to make a comment for every change. In addition, the icons for the alternate-title PDAs are shared with the PDAs they parent from, which honestly isn't an issue because that's only visible in the entity spawn menu.

@Colin-Tel Colin-Tel merged commit 7acd6c7 into DeltaV-Station:master Aug 9, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants