Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream merge take 2 #1592

Merged
merged 765 commits into from
Aug 11, 2024
Merged

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Aug 9, 2024

About the PR

from july 1 to today
meteor stuff excluded

Technical details

  • updated WhitelistRequirement to be less bad
  • moved signature system to shared and predict everything
  • remove some legacy nyano faction shit that nothing uses
  • ahelp snitching hopefully disabled
  • added names to all the nyano/deltav job icons for agent id
  • reworked loadout id stuff, instead of having 50 random places changed it now just changes the job title/icon if they weren't set in the prototype. station records now gets the id card and tries to use that.
    also removed the mind stuff so the 10 different passenger names all show up as passenger in ghost warp, less confusion
  • vox is real and all deltav/nyano jobs should be alive roundstart

a few things from before july werent merged before this for some reason so there might be things silently broken

Current Issues

  • harpies can wear jumpsuits from loadouts, with how its done now will probably be nasty to add a harpy blacklist to every single jumpsuit (they can just put on jumpsuits after spawning so i dont know why that code was even a thing)

Media

loadout id still works, but the mind's job is the actual job now not the flavour text
12:53:46
12:55:44

Changelog
🆑

  • add: Merged last months changes (except meteors) from upstream, report any issues!
  • add: SCREEEEEEEEEEE!!
  • tweak: Signing paper is now predicted.

themias and others added 30 commits August 9, 2024 18:15
* Add pen clicking sound

* switch to OnUse and reduce distance a little
Update RespiratorSystem.cs

Co-authored-by: plykiya <[email protected]>
* Change Social Anxiety ----> Stutter

* Update traits.ftl

---------

Co-authored-by: Plykiya <[email protected]>
* Adds hand labelers to the chemdrobe and ptech

* LawDrobe too

* Update cart.yml

---------

Co-authored-by: plykiya <[email protected]>
* Add support for reagents in lathes

* missing locale
* no texture machine

* done

* delete wip

* bug fixes

* oops

* CutterMachineCircuitboard
Glass: 500
* Change from obsolete method in ExplosionOverlay

* Send AppearanceSystem through constructor
* Update MoverController.cs

* Update a bunch of movement code to use Entity<T>

* Last errors

* wow, there were more errors

---------

Co-authored-by: plykiya <[email protected]>
The issue is it plays the "you hug xyz" to everyone in range as well as the target client so they overlap. IDK if anything else is broken by this but this control flow is pretty bad so I wouldn't be surprised.
…ls shuttle (#30519)

show the player a server message when they get booted from the arrivals shuttle
* handled check

* splits Handled and TryResetDelay checks
Cojoke-dot and others added 10 commits August 9, 2024 21:01
* Adds New Shoes to Sec loadouts

* Remove Cowboy stuff from sec drobe(bye sheriff) + requested changed
…ypes (#28575)

* add tooltips to agentid job icons

* forgot to stage this

* make StatusIconPrototype abstract

* minor visual improvements

* cleanup

* use currentculture to sort job names

* review
@deltanedas deltanedas marked this pull request as ready for review August 10, 2024 11:56
deltanedas and others added 12 commits August 10, 2024 12:59
* Nitrogen survival boxes

* Zero-setup workaround

* clown box

* cleanup and universal tanks

* cleanup

* more cleanup

* hide loadoutgroups

* remaining survival boxes

* space ninja

* Revert "space ninja"

This reverts commit a650f417f83f5861e0001b25418e4a361927c6c6.

* weh

* weh

* undo appearance change of syndicate survival boxes

* indentation fix and missing label
* tank harness

* weh

* Suit Storage Whitelist

* Revert "Suit Storage Whitelist"

This reverts commit b1f503573c2936642a2d7627c4852153ec71ce79.

* suit storage filter

* vox spawn gear

* weh
* Nukie species gear

* antagselectionsystem autointernals

* nukie vox

* skrek

* Remove duplicate code

* skrek

* EVA tank loadouts, vox ninja update

* fix prototype duplication

* skrek

* fix summary

* fixed empty startinggear error

* enable vox ninjas

* Comments

* removed comment because startinggearprototype should not be used on antagselection aaaanyway

* squish that if

* Update Content.Shared/Clothing/LoadoutSystem.cs

---------

Co-authored-by: metalgearsloth <[email protected]>
* Fixed potential duplicate engraved lighter steal objective

* Update Resources/Prototypes/Entities/Clothing/OuterClothing/coats.yml

Co-authored-by: Tayrtahn <[email protected]>

* Implement pigeonpeas' suggestion

* Also replaced the one if the vending machine, unsure if this vending machine is used or if vended items retain their fills, but figure can't hurt

---------

Co-authored-by: Tayrtahn <[email protected]>
@deltanedas deltanedas enabled auto-merge August 11, 2024 10:53
@deltanedas deltanedas disabled auto-merge August 11, 2024 11:26
@deltanedas deltanedas merged commit ab3c0f3 into DeltaV-Station:master Aug 11, 2024
10 of 11 checks passed
@deltanedas deltanedas deleted the upstream-ops branch August 11, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Map Changes: Sprite Changes any png or json in an rsi Changes: UI Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.