Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mothroach Operatives #1594

Closed

Conversation

DarkenedSynergy
Copy link
Contributor

@DarkenedSynergy DarkenedSynergy commented Aug 10, 2024

About the PR

Added a nuclear operative mothroach to the syndicate uplink, with fitting reinforcement radio.

Why / Balance

As spoken about in https://discord.com/channels/968983104247185448/1213723732183613480! Adds more options to the "allies" section of the uplink. Similar to the mouse operative all be it with slightly different drawbacks(increased fire damage, bigger hitbox) and benefits (faster movement without gravity, possibility to eat head clothing, being a mothroach).

Technical details

Mainly yml.

Media

Breaking changes

Changelog

🆑
add: Added mothroach operative reinforcements to the uplink to work alongside their cheesy brethren!

Add sprites + rsi and basic yaml
fix RSI errors by adding icon sprite
Adds the nuclear operative moth to the uplink and fixes the information
Adds the correct tags in the .yml, correctly credits the creator(s)
@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels Aug 10, 2024
Copy link
Contributor

github-actions bot commented Aug 10, 2024

RSI Diff Bot; head commit a286ca0 merging into a03413b
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Mobs/Animals/nukiemothroach.rsi

State Old New Status
0-equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added
mothroach-moving Added
mothroach Added
mothroach_dead Added
mothroach_lazy Added
mothroach_sleep Added

Resources/Textures/DeltaV/Objects/Devices/communication.rsi

State Old New Status
plushie-radio Added

Edit: diff updated after a286ca0

@DarkenedSynergy DarkenedSynergy marked this pull request as ready for review August 11, 2024 22:34
@DarkenedSynergy
Copy link
Contributor Author

DarkenedSynergy commented Aug 13, 2024

Had the same issue as the mouse reinforcement teleporter having the wrong parent with the recent upstream merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in the DeltaV folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delta-V folder please

@@ -2,7 +2,12 @@ ghost-role-information-nukie-mouse-name = Nuclear Operative Mouse
ghost-role-information-nukie-mouse-description = A Nuclear Operative reinforcement for the Syndicate.
ghost-role-information-nukie-mouse-rules = Normal syndicate antagonist rules apply. Work with whoever called you in, and don't harm them.
The crew is allowed to kill you without warning.
You are allowed to attack the crew and destroy the station without provocation.
You are allowed to attack the crew and destroy the station without provocation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You are allowed to attack the crew and destroy the station without provocation.
You are allowed to attack the crew and destroy the station without provocation.

Leave a line for better readability

@@ -24,7 +29,7 @@ ghost-role-information-recruiter-rules =
You are just a recruiter so do not act like a full-on antagonist, i.e. no killing people.

ghost-role-information-silvia-name = Silvia
ghost-role-information-silvia-description = You are Silvia the space snake and the CMO's charming companion.
ghost-role-information-silvia-description = You are Silvia the space snake and the CMO's charming companion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this touched?

@@ -0,0 +1,168 @@
- type: entity
name: nuclear operative mothroach
parent: MobCockroach
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this parented to Cockroach?

You can cut down the components to like... three or four by not parenting it to the cockroach

@@ -154,9 +154,6 @@
channels:
- Syndicate
# make the player a traitor once its taken
- type: AutoTraitor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing this?

@@ -90,6 +90,7 @@
- type: EmitSoundOnUse
sound: /Audio/Animals/cat_meow.ogg


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really fit in line with the cheese radio mouse operatives use; plus this is extremely valid

"copyright": "Inspired by the cheese wedge sprite from tg station https://github.com/tgstation/tgstation/blob/master/icons/obj/food/food.dmi modified by @ps3moira",
"size": {
"copyright": "Cheese radio inspired by the cheese wedge sprite from tg station https://github.com/tgstation/tgstation/blob/master/icons/obj/food/food.dmi modified by @ps3moira. plushie-radio sprited by jimbobbythe19th. ",
"size": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@TadJohnson00
Copy link
Contributor

Will require further discussion but, ideally, we'll be moving away from animal reinforcements in future (i.e. syndicats and mouse ops). Hopefully we'll have a consensus by the time this PR is up for review.

@TadJohnson00
Copy link
Contributor

@DarkenedSynergy is this PR still being worked on?

@DarkenedSynergy
Copy link
Contributor Author

@DarkenedSynergy is this PR still being worked on?

Ill probably get to it at somepoint, not an urgent thing to PR. But yes I plan on finishing this.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Sep 24, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MilonPL
Copy link
Member

MilonPL commented Nov 26, 2024

Heya! Since this PR has gotten no commits or activity in the past 3 months, I'm going to close it. If you ever come back to this, feel free to open a new PR.

@MilonPL MilonPL closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Merge Conflict Fix your PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants