Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: mail icons #1620

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Conversation

portfiend
Copy link
Contributor

About the PR

fixes #1619

Technical details

its one word

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Screenshot_179

Changelog
🆑 portfiend

  • fix: Mail now shows the job icon of the recipient again.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files labels Aug 13, 2024
@portfiend portfiend marked this pull request as ready for review August 13, 2024 16:04
@deltanedas deltanedas merged commit f0112ac into DeltaV-Station:master Aug 13, 2024
20 of 21 checks passed
@dvir001
Copy link
Contributor

dvir001 commented Aug 13, 2024

Can you also make the Icon bigger like we did on frontier?

https://github.com/new-frontiers-14/frontier-station-14/blob/cb60f83680e3dfae4cca78c01008760b75d199fc/Resources/Prototypes/Nyanotrasen/Entities/Objects/Specific/Mail/base_mail.yml#L4

    - map: ["enum.MailVisualLayers.JobStamp"]
      scale: 0.8, 0.8 # Frontier 0.5<0.8
      offset: 0.225, 0.165 # Frontier (0.275, 0.2)<(0.225, 0.165)

image

@deltanedas
Copy link
Member

wyci

LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 11, 2025
* Inertia dampeners Initial push
need to disable buttons
need to look into issue with max speed diagonal flying and changing directions

* adding new station component
hide the anchoring buttons on stations (exploit prevention)
apply station component to all POI's

* navscreen, StationComp->StationDampeningComp

* StationDampeningComp, "anchor" tense

* restore needed using statement

* Server-based dampening state

* fix entity in NfGetInertialDampeningMode

* past tense event, whitespace, comments

* ToggleStabilizer->SetInertiaDampening

* ShuttleSystem: check for shuttle deed

* Default dampening value: off->dampen

* Inertia dampeners Initial push
need to disable buttons
need to look into issue with max speed diagonal flying and changing directions

* adding new station component
hide the anchoring buttons on stations (exploit prevention)
apply station component to all POI's

* ShuttleSystem: initial query

* shuttle fix: ShuttleDeedComponent belongs to grid

* adding some logging

* Cleanup & bugfixes

* ShuttleConsole BUI: add Frontier comments

* console.ftl: dampening btns: "Cruise, Drive, Park"

---------

Co-authored-by: neuPanda <[email protected]>
Co-authored-by: Dvir <[email protected]>
Co-authored-by: Whatstone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mail no longer has job icons
3 participants