Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts AME rate of diminishing returns #1625

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

IamVelcroboy
Copy link
Member

@IamVelcroboy IamVelcroboy commented Aug 14, 2024

About the PR

Changes the AME fuel input to power output to follow a proper rate of diminishing returns.

Why / Balance

Previously we had a constant input to output increase:
Assuming a safe injection:core ratio we had,
80000/160000/240000/320000/400000/480000/560000/640000

The recent upstream merge created a bell curve drop off in returns:
120.4/180.6/175.1/152.4/126.9/103.2/82.5/65.3
The more cores you add, the less power you get.

This change would make it a proper diminishing return:
You still gain power with increased cores but less with each additional core
90,300/180,600/233,445/270,915/300,000/323,745/343,830/361,230

Technical details

n/a

Media

n/a

Breaking changes

n/a

Changelog
🆑 Velcroboy

  • tweak: Tweaked the AME to produce power with diminishing returns

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files labels Aug 14, 2024
@IamVelcroboy
Copy link
Member Author

If we wanted this to be closer to the values before such as 4-core=320k, we could increase the variable from .75 to something like .85 or .90. The diminishing return would be much more gradual/less impactful though.

@deltanedas deltanedas merged commit 3e6e4d7 into DeltaV-Station:master Aug 14, 2024
11 of 12 checks passed
MilonPL added a commit to MilonPL/Delta-v that referenced this pull request Aug 14, 2024
IamVelcroboy pushed a commit that referenced this pull request Aug 15, 2024
* Revert "Adjusts AME rate of diminishing returns (#1625)"

This reverts commit 3e6e4d7.

* we're SO BACK

* version fuck you

* no more fucky wucky fucky wuckies are gone
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 22, 2025
# Description

Updated the MacOS logo to the EE one.

Also, the base logo was 256x258, which caused me physical distress, so I
fixed that too.

# Changelog

None
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 22, 2025
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 22, 2025
This is the same as DeltaV-Station#1625, but it doesn't use symlinks, which are broken
on Windows.

# Changelog

None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants