Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual Boot Batches #1633

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Dual Boot Batches #1633

merged 4 commits into from
Sep 20, 2024

Conversation

Venrixia
Copy link
Contributor

About the PR

Adds two batch files to Simultaneously run runserver.bat and runclient.bat . Also includes tool versions.

Why / Balance

Was spoiled by EE's launch batches , made us our own dual boot batches.

Technical details

Opens runserver.bat in a CMD window set to stay open . Also does the same for runclient.bat . Performing both actions in one click instead of having to individually run both.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None

Changelog

Adds batch files to run server and client at once.

Adds two batch files to automatically run runserver.bat and runclient.bat . Also includes tool versions.
@github-actions github-actions bot added the Changes: YML Changes any yml files label Aug 15, 2024
Removes Tools batch at Danger's advice .
Re-adds Tools batch after discussion in Contribution-Help on the discord.
Adds launch batchs for Debug , as well as a dual boot batch for it .
@Venrixia
Copy link
Contributor Author

After back and forth discussion in discord. I've re-added the Tools dual-boot , as well as created batches for starting client & server in debug . Along with the associated dual-boot

@ghost ghost requested a review from deltanedas September 6, 2024 20:26
@ghost
Copy link

ghost commented Sep 6, 2024

Would this cause an issue if we merged it?

@TadJohnson00
Copy link
Contributor

@deltanedas should this be PR'd upstream or is this okay to merge here?

@deltanedas
Copy link
Member

im fine with this i wont use it either way :trollface:

@TadJohnson00
Copy link
Contributor

can haz merge then?

@deltanedas deltanedas merged commit bc82caf into DeltaV-Station:master Sep 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants