Accent Change For Character Creation Page + Irish Accent #1640
Conversation
…saach/Delta-v into funny-accent-change
github-actions
bot
added
Changes: YML
RobustToolbox
Outdated
There was a problem hiding this comment.
I don't know what to do about this as it's a submodule and automatically populated in the PR.
There was a problem hiding this comment.
This was where I was going to put the new traits, just was testing there prior and forgot about it.
| - type: trait | ||
| id: SocialAnxiety | ||
| name: trait-socialanxiety-name | ||
| description: trait-socialanxiety-desc | ||
| category: SpeechTraits | ||
| cost: 2 | ||
| cost: 1 |
There was a problem hiding this comment.
This is unrelated to your PR, and should be a commented change
There was a problem hiding this comment.
It was related due to me wanting more variety, but comments have been added-
| @@ -84,6 +82,51 @@ | |||
| name: trait-frontal-lisp-name | |||
| description: trait-frontal-lisp-desc | |||
| category: SpeechTraits | |||
| cost: 2 | |||
| cost: 1 | |||
There was a problem hiding this comment.
This is unrelated to your PR, and should be a commented change
There was a problem hiding this comment.
It was related due to me wanting more variety, but comments have been added (to all of them)
There was a problem hiding this comment.
This needs to be in a Delta-V folder.
Russian accent is really bad and leads to extremely poor readability. Should not be used.
The Descriptions are also just copy and pasted with minor edits; should be unique.
There was a problem hiding this comment.
Russian Accent was removed, traits were moved to a Delta-V folder, and I changed descriptions.
…saach/Delta-v into funny-accent-change
…saach/Delta-v into funny-accent-change
Co-authored-by: deltanedas <@deltanedas:kde.org>
I don't know why this said I changed it Signed-off-by: SsalamethVersaach <[email protected]>
SsalamethVersaach
requested review from
IamVelcroboy and
Colin-Tel
as code owners
github-actions
bot
added
S: Needs Review
S: Merge Conflict
|
Apparently GitHub has decided to PR literally EVERYTHING but my changes in this so I am just going to re-PR it, I give up on comprehending it. Apologies. |
…1640 Thanks GitHub) (#1701) * From the top! - Redid my branch... * Cleanup with some comments and explanation * Testing if Accentless is issue- failed build test * Wasn't the bug- * Changed accent weights based off int discussion * uh, forgot comment change * Changed comments a final time- reflect new weights --------- Co-authored-by: Adeinitas <[email protected]>
About the PR
This PR changed accents weights and also adds the ability to choose more accents in the character menu, as well as a new Irish accent. I did some yaml changes, along with adding a new accent.
Why / Balance
The reason behind this change was due to my own desire for people to have more accent choices, and to allow people to choose French, Russian, Spanish, Irish, and Mobster on round start. Part of this also stemmed from my desire to make it easier for players to diversify their characters.
Technical details
I changed the cost of some speech attributes in the speech.yml file, as well as added additional information and descriptions for these accents within the ftl files. In addition, I created an Irish accent which utilizes the irish.ftl and word_replacements.yml files- and added an accent system for it to function.
Media
Requirements
Breaking changes
No breaking changes (that I know of).
Changelog
🆑