Skip to content

Shoukou: Station Anchor #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from Sep 21, 2024
Merged

Shoukou: Station Anchor #1863

merged 5 commits into from Sep 21, 2024

Conversation

ghost
Copy link

@ghost ghost commented Sep 19, 2024

About the PR

Apparently he couldn't just break it into two pieces, goddamn.
Does a few things:

  • Addresses bugs reported by players (mainly an unpowered bridge machine, and the accidental reversion of deltanedas' shoukou futureproofing. Therefore, fixes Shoko pumps missing LV  #1853
  • Addresses Velcro's review (I hope I did things properly!)
  • Adds the Station Anchor to a room between the burn chambers in atmos. It's CE only access, and is kinda like a gravgen - if this makes things bad, I have no idea how to map a station anchor and this is my first time, so I'm learning.
  • Puts a bathroom in front of the bridge, millions must shit.
  • Puts the AI in the AI sat, for AI testing, and AI things. I saw Velcro was considering mapping AI into his stations and so I give you this early PR.

Why / Balance

  • I didn't mean to do things that were in the review that I missed
  • I didn't mean to accidentally revert Deltanedas' changes to Shoko-mos approved by Fish Inc.
  • This shit needs a station anchor and I didn't do it last time because I wasn't really feeling up to it given the uh. More pressing modifications of moving Epistemics and everything around.

Technical details

Map YAML, map prototype yaml.

Media

Will send some when I get this out of draft. I forgot Fixgridatmos.
image
Shifted around AI sat.
Not pictured - station anchor room or bathroom.

Requirements

Breaking changes

Changelog
🆑

  • tweak: Updated Shoko to have an anchor, and fixed bugs. Enjoy Little Port!

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Map labels Sep 19, 2024
@MilonPL
Copy link
Contributor

MilonPL commented Sep 19, 2024

pro didn't link the issue

@ghost ghost marked this pull request as ready for review September 19, 2024 09:01
@ghost ghost self-requested a review as a code owner September 19, 2024 09:01
@ghost
Copy link
Author

ghost commented Sep 19, 2024

I forgot a seed extractor and have been told to rework the AI sat once more, so it's gonna happen

adeinitas added 2 commits September 20, 2024 06:38
It's still gonna come *eventually* though, this is just setup
and the curse is manifesting, i've been trolled.
@deltanedas
Copy link
Member

if you want to add the job youll have to remove the setPreference: false line in Roles/Jobs/Science/borg.yml so players can actually ready up for it

@IamVelcroboy
Copy link
Member

if you want to add the job youll have to remove the setPreference: false line in Roles/Jobs/Science/borg.yml so players can actually ready up for it

That could be done in its own PR. Because all the maps have borg slots. Apparently, no one has been able to ready for them the whole time?

@deltanedas
Copy link
Member

the StationAi job to be clear, for whatever reason its in the same file as borg

@IamVelcroboy
Copy link
Member

Oh... That makes more sense

@IamVelcroboy
Copy link
Member

In map file change

    - type: Physics
      bodyStatus: InAir
      angularDamping: 10000
      linearDamping: 10000
      fixedRotation: False
      bodyType: Dynamic

to

    - type: Physics
      bodyStatus: InAir
      angularDamping: 0.05
      linearDamping: 0.05
      fixedRotation: False
      bodyType: Dynamic

@deltanedas
Copy link
Member

same for shuttle component

@ghost ghost changed the title Shoukou: Station Anchor, AI Shoukou: Station Anchor Sep 21, 2024
@IamVelcroboy IamVelcroboy merged commit ec2bb85 into DeltaV-Station:master Sep 21, 2024
11 checks passed
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Mar 9, 2025
…Eyes, Etc, Fixes, IPCs Now Can't Take the Basic Cyber Eyes Trait. (DeltaV-Station#1863)

WHAT IT SAYS ON THE TITLE

<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Got to fix the IPC issue with eye traits etc, IPCs can't grab the basic
cyber eyes trait, and such.

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [ ] Task
- [x] Completed Task

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

![Example Media Embed](https://example.com/thisimageisntreal.png)

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: Diggy
- tweak: IPCs can't grab the basic cyber eyes trait (Why would u do that
stoopid), added most of my traits to the mind over machine stuff, IPC
eye traits now prevent bad eye traits.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Expanded character customization by adding new traits that offer
enhanced repair, mobility, and advanced visual/sensor capabilities.
  
- **Refactor**
- Revised trait prerequisites and refined species-specific conditions to
deliver more nuanced character development and balanced interactions.
  
- **Style**
- Updated the trait name for "Bionic Leg" to "Bionic Legs" for clarity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shoko pumps missing LV
3 participants