Scar and Tattoo Fixes #1889
Merged
Scar and Tattoo Fixes #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes chest tattoos showing through clothes on females. Signed-off-by: Aikakakah <[email protected]>
Fixes the chest scar showing through clothes on females. Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
…ling.png Signed-off-by: Aikakakah <[email protected]>
…chest.png Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
github-actions
bot
added
S: Needs Review
Changes: YML
|
RSI Diff Bot; head commit 37ff78f merging into 02f8188 Resources/Textures/DeltaV/Mobs/Customization/scars.rsi
Resources/Textures/DeltaV/Mobs/Customization/tattoos.rsi
|
ghost
reviewed
Sep 22, 2024
There was a problem hiding this comment.
All this looks like is splitting of the markings - most of which touches upstream files. I'd say maybe go fix this in an upstream PR (at space-wizards/space-station-14), - that might take a while though. If you wanna get this accepted here though, you're gonna have to like heavily split it so that things are either DeltaV commented or make a few DeltaV files for tattoos.
Resources/Prototypes/Entities/Mobs/Customization/Markings/scars.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Mobs/Customization/Markings/scars.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Mobs/Customization/Markings/scars.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Mobs/Customization/Markings/tattoos.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Mobs/Customization/Markings/tattoos.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Mobs/Customization/Markings/tattoos.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Mobs/Customization/Markings/tattoos.yml
Outdated
Show resolved
Hide resolved
|
Edited it further to keep all original files in their respective folder, new changes are in the DeltaV folder. |
MilonPL
suggested changes
Sep 24, 2024
Resources/Prototypes/Entities/Mobs/Customization/Markings/scars.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Mobs/Customization/Markings/tattoos.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Mobs/Customization/Markings/tattoos.yml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixed the issue of chest tattoos showing through clothes. Includes a fix for the back of the Nightling chest tattoo showing on the back of the neck on males and all chest tattoos and scars showing through clothing on females.
Why / Balance
I saw it. It annoyed me. I fixed it.
Technical details
Added male and female variations of affected scars/tattoos.
Media
Green Nightling tattoo on female.
Requirements
Breaking changes
Changelog
🆑