-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new station: Lobster Station (Second PR, ignore the first one) #2094
Open
PubliclyExecutedPig
wants to merge
142
commits into
DeltaV-Station:master
Choose a base branch
from
PubliclyExecutedPig:map-testing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adds new station: Lobster Station (Second PR, ignore the first one) #2094
PubliclyExecutedPig
wants to merge
142
commits into
DeltaV-Station:master
from
PubliclyExecutedPig:map-testing
+113,929
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds lobster station
github-actions
bot
added
Changes: YML
Changes any yml files
Changes: Map
S: Needs Review
labels
Nov 2, 2024
You need to update the integration tests to include Lobster station. (edit: linked wrong code) |
hopefully this fixes the error thingy
well i've fixed that and the test still fails :/ |
you dont need to merge master every 5 seconds |
you cant stop me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: Map
Changes: YML
Changes any yml files
S: Needs Review
size/XL
Over 1024 lines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lobster station
About the PR
Lobster station, named because its shaped like a lobster, is a modern and expensive station, mainly focussed on research and development, income from passengers (like a resort), with a strong security to back it
Why / Balance
To add some variation to the map pool, especially on apoapsis, whilst being quite unique in its characteristics... kinda like a dv fland station (but hopefully better, also this is a second PR bc idk how to update my first one's files)
Technical details
Media
Requirements
Breaking changes
Changelog
🆑-add: Lobster Station, a medium pop station! (actual lobster is not guaranteed and is at the discretion of the chefs)