Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail carrier hood. AAAAAAAAAAAAH!! #2113

Merged

Conversation

Monotheonist
Copy link
Contributor

@Monotheonist Monotheonist commented Nov 4, 2024

About the PR

fixes #781, gives the mail carrier a hood. Literally playable 😃
This gives the mail carrier a hood to their coat.

Why / Balance

It's crucial for the balance of the game, mail carriers everywhere have been deprived of their right for TOO LONG. I'm just kidding but I saw that I could fix this issue and so I did.

Technical details

Currently YAML and sprites.

Media

This is a hood, the sprite's in the diff. I don't got much else to say.

Requirements

Breaking changes

Changelog

No CL no fun.

@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an rsi label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

RSI Diff Bot; head commit cc7dfaa merging into 60f3949
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Head/Hoods/Coat/hoodmail.rsi

State Old New Status
equipped-HELMET Added
icon Added

Edit: diff updated after cc7dfaa

@Monotheonist Monotheonist changed the title Sprite the actual hood, tell me what I'm missing. mail carrier hood. AAAAAAAAAAAAH!! Nov 4, 2024
@Monotheonist
Copy link
Contributor Author

why the fuck did i name it that. oh my god. crying.

@deltanedas
Copy link
Member

  1. add a new hood entity, copy paste the logistics one and change the id/sprite/name
  2. change the coats parent to ClothingOuterWinterCoatToggleable
  3. add
- type: ToggleableClothing
  clothingPrototype: ClothingHeadHatHoodWinterMailCarrier

to the mail carrier winter coat

@github-actions github-actions bot added the Changes: YML Changes any yml files label Nov 15, 2024
@Monotheonist Monotheonist marked this pull request as ready for review November 15, 2024 10:45
@Monotheonist Monotheonist requested review from IamVelcroboy and a team as code owners November 15, 2024 10:45
@Monotheonist
Copy link
Contributor Author

I addressed it, my small yaml PR should be ready for your consideration @deltanedas

@Monotheonist
Copy link
Contributor Author

There you go, are we good?

deltanedas
deltanedas previously approved these changes Nov 16, 2024
@deltanedas deltanedas enabled auto-merge (squash) November 16, 2024 14:05
@github-actions github-actions bot added the size/S 16-63 lines label Nov 24, 2024
@Monotheonist
Copy link
Contributor Author

The tests aren't testing 😿

auto-merge was automatically disabled December 6, 2024 04:09

Head branch was pushed to by a user without write access

@Monotheonist
Copy link
Contributor Author

I'M FREE FROM THE CONSTANT TEST FAILS!!! @deltanedas @MilonPL

@MilonPL MilonPL merged commit 868297b into DeltaV-Station:master Dec 6, 2024
16 checks passed
@Monotheonist Monotheonist deleted the mail-carrier-in-da-hood-ops branch December 6, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mail carrier winter coat has no hood
3 participants