Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contributing guidelines and update github stuff #2119

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

deltanedas
Copy link
Member

About the PR

added CONTRIBUTING.md for the PR template and for the wiki to link to
its linked at the top of the template now to make it easy to find probably.

Why / Balance

new contributors didnt get explicitly told any deltav conventions :trollface:

also old MARKERS.md link didnt exist :trollface:

Technical details

no

Media

no

Requirements

Breaking changes

no

Changelog
no cl no fun

@github-actions github-actions bot added the Changes: Documentation Changes any xml or md files label Nov 4, 2024
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@@ -1,4 +1,4 @@
<!-- Guidelines: https://docs.spacestation14.io/en/getting-started/pr-guideline -->
<!-- If you are new to the Delta-V repository, please read the [Contributing Guidelines](https://github.com/DeltaV-Station/Delta-v/blob/master/CONTRIBUTING.md) -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just use the wiki if you want to, we have the means

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i originally wanted to put it on the wiki but mediawiki is so ass and doesnt even have multitline code blocks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can install SyntaxHighlight or something if you want me to

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pro
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still good to have here as well so you can read it offline or if the wiki dies (not that it ever would :trollface:)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah just mirror it to the wiki, sucks to have it maintained in two different places but it's not like there's going to be changes to this often

CONTRIBUTING.md Outdated Show resolved Hide resolved
@Stop-Signs
Copy link
Contributor

Finally I can stop getting audited over the silly #

@deltanedas deltanedas merged commit d7667f3 into DeltaV-Station:master Nov 6, 2024
11 checks passed
@deltanedas deltanedas deleted the pr-ops branch November 6, 2024 21:08
@deltanedas
Copy link
Member Author

its being enforced already :trollface:

@MilonPL
Copy link
Member

MilonPL commented Nov 6, 2024

its being enforced already :trollface:

i was waiting on you to change the link and that never came...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Documentation Changes any xml or md files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants