-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add contributing guidelines and update github stuff #2119
Conversation
@@ -1,4 +1,4 @@ | |||
<!-- Guidelines: https://docs.spacestation14.io/en/getting-started/pr-guideline --> | |||
<!-- If you are new to the Delta-V repository, please read the [Contributing Guidelines](https://github.com/DeltaV-Station/Delta-v/blob/master/CONTRIBUTING.md) --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could just use the wiki if you want to, we have the means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i originally wanted to put it on the wiki but mediawiki is so ass and doesnt even have multitline code blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can install SyntaxHighlight or something if you want me to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still good to have here as well so you can read it offline or if the wiki dies (not that it ever would )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah just mirror it to the wiki, sucks to have it maintained in two different places but it's not like there's going to be changes to this often
Finally I can stop getting audited over the silly # |
its being enforced already |
i was waiting on you to change the link and that never came... |
About the PR
added CONTRIBUTING.md for the PR template and for the wiki to link to
its linked at the top of the template now to make it easy to find probably.
Why / Balance
new contributors didnt get explicitly told any deltav conventions
also old MARKERS.md link didnt exist
Technical details
no
Media
no
Requirements
Breaking changes
no
Changelog
no cl no fun