Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPO QOL items and stamps update+ #2155

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Unkn0wnGh0st333
Copy link
Contributor

@Unkn0wnGh0st333 Unkn0wnGh0st333 commented Nov 8, 2024

About the PR

Finishes #2003 cause I wanted it really bad while also changing a lot of other small things I personally felt should have been added.

I checked the users profile and they haven't been on gihub since the 13th last month. If they take offense to this I apologize and will take down the PR.

Why / Balance

Quote sheepism1 on GitHub

Binary keys to spy on the silicon too, blenders so they can make meds (they could just eat it before) and additional stamps to ensure there's plenty of tomfoolery that you can get up to impersonating the Psychologist, Chief Justice, Lawyer, or Greytide. Balance for the kitty isn't really required cause it's just fluff

Also because its been 3 weeks with no progress. I'm sorry Sheepism but this is a change I was really excited for.

Technical details

sheepism1 on GitHub changes:

  • Added binary key to interceptor headsets (NOT THE NUKIE OR TRAITOR ONES, ONLY THE LP ONES)
  • Added a kitty spawner (generic)
  • Added a bruise-o-mat (also emagged)
  • Blender for.. I dunno, more options to do in Syndicate Botany. LARP as a synthesis specialist!
  • Stamps are put in the locker, not prototyped cause fun fact it's just a renamed locker
  • Station warrant paper for more smoke and mirrors :trollface:

My personal changes:

  • Made sure the Syndicate had SYNDICATE BINARY KEYS and not normal binary keys cause the little things matter (no one would have ever noticed)
  • Adds an IFF computer
  • Changed Drink Vendor Spawner to Emagged Robust Softdrinks (For Emagged variable)
  • Changed Random Snack Vendor for Emagged Getmore Chocalate Corp (For Emagged variable)
  • Changed Microwave for a Donk Co. Microwave
  • Added "emergency" Blood-Red Phone (If something were to ever go wrong...)
  • Added Syndicate Business Cards :trollface:
  • Added Mountain Rock and Salvage scrap spawns to make the asteroid more "realistic" compared to the others
  • Added a super evil chasm on one side :trollface: (But don't worry, these warning cones!)
  • Added Syndicate Towel and Interdyne Defib in the bathroom
  • Added another clothing wall locker (includes 5 more uniforms, 2 combat boots, and a cybersun windbreaker)
  • Changed disposal unit for fancy "space disposal unit" in botany
  • Added Syndicate Codewods Registry on the filing cabinet in the main room (it will only show active codewords and won't update)

Edit:

  • Added LPO Stamp Locker so now all newly added stamps are just a yaml fix

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Kills us all

Changelog
🆑 sheepism1, Unkn0wnGh0st333

  • tweak: Added QOL items, additional stamps, and more to the Listening Post, and binary keys are now on
    Listening Post Operative headsets by default. Not even the Borgs are safe from snooping!

Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Unkn0wnGh0st333
Copy link
Contributor Author

#2003 (review)

Yeah I was thinking about it and was like "why isn't this like.. it's own locker so we could just change the yaml"

@sheepism1
Copy link

Sheepism here! you did it justice, please just add an IFF console somewhere so Salv doesn't come, see, and conquer instantly.

@sheepism1
Copy link

I do want to name the cat "Sandy Cat" and make them calico

@sheepism1
Copy link

also please don't take down the PR, it is a suitable continuation (way better than what I could have done really)
image

@Radezolid
Copy link
Contributor

Sheepism here! you did it justice, please just add an IFF console somewhere so Salv doesn't come, see, and conquer instantly.

IFF console would be useless since you're surrounded by other grids

@sheepism1
Copy link

I mean, its still harder to spot out I think

@sheepism1
Copy link

not "complete stealth" more "low-observable"

@Unkn0wnGh0st333
Copy link
Contributor Author

Sheepism here! you did it justice, please just add an IFF console somewhere so Salv doesn't come, see, and conquer instantly.

oh my god you're alive, also yeah I forgot the IFF. I'll add that :blunt:

@sheepism1
Copy link

I would take out BaseAdvancedPen cause it might just be a generic prototype, if you want a luxury pen I think that IS in the game. maybe replace with HOP or Cap's fountain pen.

sheepism1

This comment was marked as duplicate.

@Unkn0wnGh0st333
Copy link
Contributor Author

I would take out BaseAdvancedPen cause it might just be a generic prototype, if you want a luxury pen I think that IS in the game. maybe replace with HOP or Cap's fountain pen.

Advanced is already gone, and yes the luxury pen exist. It's primarily used by justice department.

deltanedas
deltanedas previously approved these changes Nov 29, 2024
@deltanedas
Copy link
Member

defering to @IamVelcroboy for mapping, the prototype looks good though

@sheepism1
Copy link

thank you deltanedas

- type: MetaData
name: Map Entity
- type: Transform
- type: Map
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you save the map as grid? As in, did you use the cmd, savegrid and not savemap

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my closed PR it was save gridded but it seems they recreated it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rookie mistake -700 aura 😔

Resources/Maps/Shuttles/DeltaV/listening_post.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the size/XL Over 1024 lines label Dec 2, 2024
@Radezolid
Copy link
Contributor

Ya still working on this? If not I want to PR the binary key to the LPO.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 1, 2025
@deltanedas
Copy link
Member

map still needs to be converted to a grid

@deltanedas deltanedas added S: Awaiting Changes Do not merge due to requested changes and removed S: Needs Review labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Map Changes: YML Changes any yml files S: Awaiting Changes Do not merge due to requested changes size/XL Over 1024 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants