Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space law guidebook #2187

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Unkn0wnGh0st333
Copy link
Contributor

@Unkn0wnGh0st333 Unkn0wnGh0st333 commented Nov 13, 2024

About the PR

Takes the cool part out of #2076 and slaps it in its own PR

Delayed until LadyDangers Space Law Update

Why / Balance

Do we really need to discuss why

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an in-game showcase.

Changelog
🆑 MilonPL, Unkn0wnGh0st333

  • add: Space Law and SOP have been added to the guidebooks. Space Law books will now work as intended.

@Unkn0wnGh0st333 Unkn0wnGh0st333 marked this pull request as ready for review November 13, 2024 04:56
@Lyndomen
Copy link
Contributor

fire emoji

@LadyDanger2743
Copy link

Love this a lot, looking forward to it being in the game, Direction gold star of approval.

As a warning, though, I'm working on a rewrite of SOP/SpLaw/CoPo, nearly finished everything. Don't let that stop the merge, but be advised that I'll need a hand in updating the guidebook entries with the new documents if you merge this before I'm ready to update the documentation.

@Unkn0wnGh0st333 Unkn0wnGh0st333 requested a review from a team as a code owner December 6, 2024 22:36
@github-actions github-actions bot added S: Needs Review size/XL Over 1024 lines Changes: YML Changes any yml files Changes: Localization Changes any ftl files Changes: Documentation Changes any xml or md files labels Dec 6, 2024
@deltanedas
Copy link
Member

10:52:16

@deltanedas deltanedas requested a review from a team as a code owner December 17, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/XL Over 1024 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants