Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stamina damage resist #2190

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

MilonPL
Copy link
Member

@MilonPL MilonPL commented Nov 13, 2024

About the PR

adds a resist to incoming projectile stamina damage
most hardsuits provide a 10% protection, sec and syndicate hardsuits provide 70% protection, with exceptions for raid suits, jugg, elite, hos, warden, etc, whatever makes sense to be higher
melee damage like batongs either takes the blunt damage coefficient or the melee stamina damage coefficient on the armor, whichever one provides more resist

Why / Balance

stumeta bad and i'm cooking

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • tweak: Hardsuits and armor vests now provide protection against incoming stamina damage.

@MilonPL MilonPL requested review from a team as code owners November 13, 2024 19:34
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files labels Nov 13, 2024
@MilonPL MilonPL mentioned this pull request Nov 13, 2024
2 tasks
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like an old prs stamina damage specifiers better, allows for more control over the different types of stuns

also the logic for not having an examine is terrible, if theres no examine the average player wont know it exists and the pro gamers will just grep the source anyway giving them an advantage

@MilonPL
Copy link
Member Author

MilonPL commented Nov 13, 2024

also the logic for not having an examine is terrible, if theres no examine the average player wont know it exists and the pro gamers will just grep the source anyway giving them an advantage

yes real i'm just coping with stamina not being a damage type

i think that melee weapons should use the stamina resist based on blunt damage coefficient rather than having a separate value, and then the StaminaDamageCoefficent only works for projectiles (or maybe takes the higher value out of the two?)

@Lyndomen
Copy link
Contributor

Lyndomen commented Nov 13, 2024

I had started work on this yesterday to do a similar thing, by changing the YAML of all stamina weps to use bluntdamagestamina, which is then reduced by armor. Was advised this was maints hell

I also made shockdamagestamina exist, so shock damage can similarly do stam damage. I moved baton to shock, and the goal is blunt = good at stunning unarmored and shock = good at stunning armored but still slightly worse than it is now.

3749fca

I guess some guidance about what is best would be great

@ThataKat
Copy link
Contributor

Particulars might have to be tweaked but holy based. No more stunning nukies with rubbers?

@Stop-Signs
Copy link
Contributor

I really appreciate someone taking the time to do this. I do agree with delta in that you should be able to examine to see the stamina res, else it's only going to be abused by the "pros" and noobs will have a harder time understanding.

@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Nov 14, 2024
deltanedas
deltanedas previously approved these changes Nov 14, 2024
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stunmeta is dead piemeta is new king

@deltanedas
Copy link
Member

change cl to reflect batong change

@MilonPL
Copy link
Member Author

MilonPL commented Nov 14, 2024

change cl to reflect batong change

hold on i was cooking

@MilonPL MilonPL requested a review from deltanedas November 14, 2024 08:24
@MilonPL
Copy link
Member Author

MilonPL commented Nov 14, 2024

conflicts no longer that evil

@MilonPL MilonPL changed the title stamina projectile damage resist stamina damage resist Nov 14, 2024
@MilonPL MilonPL requested a review from deltanedas November 14, 2024 14:15
@deltanedas deltanedas enabled auto-merge (squash) November 14, 2024 14:19
@deltanedas
Copy link
Member

nukies are back

@deltanedas deltanedas merged commit f580084 into DeltaV-Station:master Nov 14, 2024
12 checks passed
@MilonPL MilonPL deleted the stunmeta-kill branch November 14, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants