Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeadRum, The Quest for More Rum #2202

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

jtbill123
Copy link
Contributor

@jtbill123 jtbill123 commented Nov 15, 2024

About the PR

Changed the YML to add in a recipe for DeadRum

Why / Balance

DeadRum currently only exists on a medium salv wreck with no indication that it is anything different. As such i created a recipe so bartenders can gain access to it without salv.

Technical details

Created recipe

DeadRum:
1 part Saline
1 part Salt
1 part Rum
makes 3 parts DeadRum

Media

None

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

I have not checked to see if the recipe was added to the guide book

Changelog
🆑

  • add: Added a recipe for Dead Rum. MORE DRINKS!

DeltaV-Bot and others added 4 commits November 15, 2024 02:10
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Merging with masterbranch
@jtbill123 jtbill123 requested a review from a team as a code owner November 15, 2024 08:12
@github-actions github-actions bot added Changes: YML Changes any yml files S: Needs Review labels Nov 15, 2024
deltanedas
deltanedas previously approved these changes Nov 15, 2024
@MilonPL
Copy link
Member

MilonPL commented Nov 17, 2024

Changelog isn't up to standards, it should reflect what's changed so that the player doesn't have to guess

Added the DeadRum drink recipe.

@Monotheonist
Copy link
Contributor

Changelog isn't up to standards, it should reflect what's changed so that the player doesn't have to guess

Added the DeadRum drink recipe.

It's now "add: MORE DRINKS! New RUM!," is that up to standard?

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/XS Under 16 lines and removed S: Merge Conflict Fix your PR! labels Jan 1, 2025
@deltanedas deltanedas enabled auto-merge (squash) January 1, 2025 14:51
@deltanedas deltanedas merged commit 35d5f3f into DeltaV-Station:master Jan 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review size/XS Under 16 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants