Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HydroCo - Beverage Powders #2210

Merged

Conversation

DisposableCrewmember42
Copy link
Contributor

@DisposableCrewmember42 DisposableCrewmember42 commented Nov 16, 2024

About the PR

  • Added HydroCo Dairy and Juice crates. They contain beverage powders that, when mixed with water in a 1:1 ratio and stirred, create the advertised beverage.
  • Each tin contains 50u of powder, which can create 100u of liquid
  • The dairy crate costs 1500 Spesos and contains
    • 2 Milk tins
    • 2 Soy Milk tins
  • The juice crate costs 1500 Spesos and contains one tin of each group
    • Citrus
      • Orange
      • Lime
      • Lemon
    • Tropical
      • Pineapple
      • Banana
      • Watermelon
    • Berry
      • Berry
      • Grape
      • Cherry
    • Garden
      • Apple
      • Carrot
      • Tomato
  • Both crates also contain two spoons and a note from HydroCo
  • The HydroCo (HYD) stock was added to StockTrade
  • If powder is eaten straight, it causes coughing. If more than 15u is consumed, there is a chance of vomiting.
  • The more acidic juice powders (pineapple, lemon, lime) cause 1 caustic damage per unit consumed
  • Added mail containing one random tin of hydroco powder with a note
  • Added 2 tins of soy milk powder and 1 tin of orange juice powder to the Sustenance Vendor (commonly found in Perma)

Why / Balance

Requested in The Drawing Board and further discussed in a dedicated thread.

Regarding balance:
I believe the prices are justified and high enough to discourage buying lots of juice instead of cooperating with Botany, especially since you can't order specific types in bulk.

Technical details

YML changes mostly in line with everything else in each file/category. For the tins, I created a new base type, since neither the FoodTinBase prototype nor the ReagentPacketBase suited my exact needs.

The texture uses the Sprite color attribute and an overlay to avoid lots of pointless and tiring work, and make it easy to add new types in the future.

Media

orders
tins
stonks
notice
inspect

pr-hydroco-powders.mp4
pr-hydroco-powders-cough-vomit.mp4

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑 DisposableCrewmember42

  • add: NanoTrasen has established business relations with HydroCo! You can now order powdered milk and juice via your Logistics department and bet on the growth of the HYD stock.

@github-actions github-actions bot added Status: Needs Review Changes: YML Changes any yml files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi and removed Status: Needs Review labels Nov 16, 2024
Copy link
Contributor

github-actions bot commented Nov 16, 2024

RSI Diff Bot; head commit 0d71dae merging into d4d22c9
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Consumable/Drinks/powdered_drinks.rsi

State Old New Status
icon-open Added
icon-order-dairy Added
icon-order-juices Added
icon Added
overlay-container Added

Edit: diff updated after 0d71dae

@IamVelcroboy
Copy link
Member

This is really neat. My main suggestion would be to reduce the contents of the fruit crates to 4 and use rng group tables.
With like:

  • group 1 citrus (Lemon, Lime, Orange)
  • group 2 berry (berry, cherry, grape)
  • group 3 tropical (pineapple, banana, watermelon)
  • group 4 other (apple, carrot)

@dvir001
Copy link
Contributor

dvir001 commented Nov 17, 2024

Please add a crate for energy drinks versions. (GFuel, GamerSupps).

Call it GamerDonkCo / CyberFuel / SyndijuiceSupps etc

@IamVelcroboy
Copy link
Member

Another suggestion, one or two of these would probably be a good addition to the perma SusVend

@Avalon-Proto
Copy link
Contributor

Another suggestion, one or two of these would probably be a good addition to the perma SusVend

Speaking of that machine, it needs a restock or something. Currently doesn't have one and it'd be nice to be able to restock it so the Perma players have somewhat reliable food besides what they make

@IamVelcroboy
Copy link
Member

Another suggestion, one or two of these would probably be a good addition to the perma SusVend

Speaking of that machine, it needs a restock or something. Currently doesn't have one and it'd be nice to be able to restock it so the Perma players have somewhat reliable food besides what they make

Definitely out of scope for this PR but it would be an easy PR for anyone to do.

@DisposableCrewmember42
Copy link
Contributor Author

Please add a crate for energy drinks versions. (GFuel, GamerSupps).

Call it GamerDonkCo / CyberFuel / SyndijuiceSupps etc

I'll probably PR more variations of beverages at a later point, but I'd consider that out of scope for now. I was thinking of also adding syrups for SpaceUp and stuff like that, but powdered energy drinks would work too.

@DisposableCrewmember42
Copy link
Contributor Author

This is really neat. My main suggestion would be to reduce the contents of the fruit crates to 4 and use rng group tables. With like:

* group 1 citrus (Lemon, Lime, Orange)

* group 2 berry (berry, cherry, grape)

* group 3 tropical (pineapple, banana, watermelon)

* group 4 other (apple, carrot)

Makes sense, I'll do that and reduce the price to 1500.

@DisposableCrewmember42
Copy link
Contributor Author

oh god i fucked up the rebase

@DisposableCrewmember42
Copy link
Contributor Author

This doesn't modify C#, label can be removed. Should be the final changes, ready for review!

@IamVelcroboy IamVelcroboy removed the Changes: C# Changes any cs files label Nov 18, 2024
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Audio Changes any audio files labels Nov 19, 2024
@DisposableCrewmember42
Copy link
Contributor Author

DisposableCrewmember42 commented Nov 19, 2024

i rebased and reworded a commit to retrigger the flaky test and did the thing again, apparently that's not a great idea after merge commit :blunt:

Copy link
Member

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the size/L 256-1023 lines label Nov 24, 2024
@DisposableCrewmember42
Copy link
Contributor Author

test failures unrelated

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Nov 25, 2024
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Nov 25, 2024
@DisposableCrewmember42
Copy link
Contributor Author

Conflicts resolved

@MilonPL MilonPL enabled auto-merge (squash) November 29, 2024 09:39
@MilonPL MilonPL merged commit 14e0c3f into DeltaV-Station:master Nov 29, 2024
16 checks passed
@DisposableCrewmember42 DisposableCrewmember42 deleted the hydroco-powdered-drinks branch December 1, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants