-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HydroCo - Beverage Powders #2210
feat: HydroCo - Beverage Powders #2210
Conversation
RSI Diff Bot; head commit 0d71dae merging into d4d22c9 Resources/Textures/DeltaV/Objects/Consumable/Drinks/powdered_drinks.rsi
|
This is really neat. My main suggestion would be to reduce the contents of the fruit crates to 4 and use rng group tables.
|
Please add a crate for energy drinks versions. (GFuel, GamerSupps). Call it GamerDonkCo / CyberFuel / SyndijuiceSupps etc |
Another suggestion, one or two of these would probably be a good addition to the perma SusVend |
Speaking of that machine, it needs a restock or something. Currently doesn't have one and it'd be nice to be able to restock it so the Perma players have somewhat reliable food besides what they make |
Definitely out of scope for this PR but it would be an easy PR for anyone to do. |
I'll probably PR more variations of beverages at a later point, but I'd consider that out of scope for now. I was thinking of also adding syrups for SpaceUp and stuff like that, but powdered energy drinks would work too. |
Makes sense, I'll do that and reduce the price to 1500. |
oh god i fucked up the rebase |
750b4ca
to
b0eee72
Compare
This doesn't modify C#, label can be removed. Should be the final changes, ready for review! |
890eb98
to
64eeb91
Compare
* meow * meow * Update DeltaVChangelog.yml Signed-off-by: Lyndomen <[email protected]> --------- Signed-off-by: Lyndomen <[email protected]>
64eeb91
to
414778c
Compare
i rebased and reworded a commit to retrigger the flaky test and did the thing again, apparently that's not a great idea after merge commit :blunt: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resources/Prototypes/DeltaV/Entities/Objects/Consumable/Drinks/powdered_drinks.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Objects/Consumable/Drinks/powdered_drinks.yml
Outdated
Show resolved
Hide resolved
test failures unrelated |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: DisposableCrewmember42 <[email protected]>
Conflicts resolved |
About the PR
Why / Balance
Requested in The Drawing Board and further discussed in a dedicated thread.
Regarding balance:
I believe the prices are justified and high enough to discourage buying lots of juice instead of cooperating with Botany, especially since you can't order specific types in bulk.
Technical details
YML changes mostly in line with everything else in each file/category. For the tins, I created a new base type, since neither the FoodTinBase prototype nor the ReagentPacketBase suited my exact needs.
The texture uses the Sprite color attribute and an overlay to avoid lots of pointless and tiring work, and make it easy to add new types in the future.
Media
pr-hydroco-powders.mp4
pr-hydroco-powders-cough-vomit.mp4
Requirements
Breaking changes
Changelog
🆑 DisposableCrewmember42