Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Deck the Halls" by Kevin Macleod #2233

Merged
merged 12 commits into from
Nov 19, 2024

Conversation

Lyndomen
Copy link
Contributor

@Lyndomen Lyndomen commented Nov 18, 2024

About the PR

Draft PR, I havent purchased a license yet or uploaded anything. Do we want it on the jukebox:trollface:

Why / Balance

what a banger

Technical details

yaml

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
🆑

  • add: Added holiday cheer

@github-actions github-actions bot added the Changes: YML Changes any yml files label Nov 18, 2024
@therealDLondon
Copy link
Member

If you're willing to pay the 200 bucks I am 100% on board

@MilonPL
Copy link
Member

MilonPL commented Nov 18, 2024

it would be REALLY funny

@Lyndomen
Copy link
Contributor Author

I am on record that I will pay $200

@Unkn0wnGh0st333
Copy link
Contributor

The peak in question

@therealDLondon
Copy link
Member

I am on record that I will pay $200

Then do it, im using my 1 "merge this" token, do it
Add it to the lobby, and the jukebox, also make it a nuke countdown song :trollface:

@dvir001
Copy link
Contributor

dvir001 commented Nov 18, 2024

image

@ThataKat
Copy link
Contributor

I would lose my shit if this was a nuke countdown song. Official opinion of Direction pending

@ThisIsIPat
Copy link

It could replace every single lobby song. That's the only song that plays.

@CybersunOperative
Copy link

hi official opinion of direction here (trust). If you can resolve the license, then by all means, add it to the jukebox. Might be funny, I would laugh.

@boogiebogus
Copy link
Contributor

can we add a rule to make people who play it valid

@IamVelcroboy
Copy link
Member

This is evil

@github-actions github-actions bot added the Changes: Audio Changes any audio files label Nov 19, 2024
@Lyndomen
Copy link
Contributor Author

1984 so it turns out $200 is a scam or something and a real license for the OG shit would be thousands of dollars. i have a house to remodel so that aint it chief.

in return we get
image

deck the halls, royalty free and in public domain by kevin macleod king of all shitty youtube videos

im still looking into the legality of CC-BY covers, as someone is sharing a "All I want for christmas is you" cover as CC-BY but that might not be real, idk

@Colin-Tel
Copy link
Contributor

I dig it

@Lyndomen
Copy link
Contributor Author

oh real not draft

@Lyndomen Lyndomen marked this pull request as ready for review November 19, 2024 03:55
@Lyndomen Lyndomen requested a review from a team as a code owner November 19, 2024 03:55
@Lyndomen Lyndomen changed the title Add "All I Want For Christmas Is You" by Mariah Carey Add "Deck the Halls" by Kevin Macleod Nov 19, 2024
@Colin-Tel Colin-Tel merged commit b05a292 into DeltaV-Station:master Nov 19, 2024
11 checks passed
DisposableCrewmember42 pushed a commit to DisposableCrewmember42/Delta-v that referenced this pull request Nov 19, 2024
* meow

* meow

* meow

* meow

* meow

* meow

* meow

* meow
@Lyndomen Lyndomen deleted the christmasops branch November 20, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.