-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Height & Records Computer from Cosmatic Drift #2236
base: master
Are you sure you want to change the base?
Conversation
Sooo what does this do- |
I'd rather not have heights particularly cause hitboxes and all, though I wooould like for bitz' height of 3'11" to be reflected i'd rather also not just have the game become be "small size to be hard to hit" Records though GIVE GIVE ME THEM NOW |
Height is just a text field it doesn't do that |
Their actual height slider intentionally doesn't change hotboxes, it's fine to port. |
Heard and agreed. I was thinking of only permitting sizes to be +/- 10% default species size, so a max of 20% between the tallest and shortest member of the same species. |
Hello, I am the original author of this. I strongly recommend that you remove all CD migrations and re-generate your own. This will likely reduce the size of this PR by at least 10k lines of code. They are needed on CD because the original DB model was not very good due to my inexperience with database work. I would also strongly recommend that you make sure the model fits with what DV is doing and rename the cdprofile table accordingly (or merge it with the equivalent DV table). Hope this helps |
If I remember correctly it can make it harder to leftclick swing on people but I am not 100% sure about that. |
Yep, the height in records was intentionally separated from the slider because players may want to have height values that we don't support on the slider. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About the PR
Title
Why / Balance
Records computer is sweet
Technical details
Port, untested while draft
Media
not yet
Requirements
Breaking changes
Changelog
🆑