Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Height & Records Computer from Cosmatic Drift #2236

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Lyndomen
Copy link
Contributor

About the PR

Title

Why / Balance

Records computer is sweet

Technical details

Port, untested while draft

Media

not yet

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
🆑

  • add: Ported the Records information from Cosmatic Drift! Idk

@github-actions github-actions bot added Changes: UI Changes: C# Changes any cs files labels Nov 19, 2024
@Unkn0wnGh0st333
Copy link
Contributor

Sooo what does this do-

@Kr8art
Copy link
Contributor

Kr8art commented Nov 19, 2024

Sooo what does this do-

On Cosmatic Drift you can add employment, medical and security records to your character, and other people can look them up on station record computers. It's basically just an RP/flavour thing.

image

@Unkn0wnGh0st333
Copy link
Contributor

Sooo what does this do-

On Cosmatic Drift you can add employment, medical and security records to your character, and other people can look them up on station record computers. It's basically just an RP/flavour thing.

image

Wait I've actually been waiting for something like this, peak alert?

@BlitzTheSquishy
Copy link
Contributor

I'd rather not have heights

particularly cause hitboxes and all, though I wooould like for bitz' height of 3'11" to be reflected i'd rather also not just have the game become be "small size to be hard to hit"

Records though GIVE GIVE ME THEM NOW

@Lyndomen
Copy link
Contributor Author

I'd rather not have heights

particularly cause hitboxes and all, though I wooould like for bitz' height of 3'11" to be reflected i'd rather also not just have the game become be "small size to be hard to hit"

Records though GIVE GIVE ME THEM NOW

Height is just a text field it doesn't do that

@MilonPL
Copy link
Member

MilonPL commented Nov 19, 2024

Their actual height slider intentionally doesn't change hotboxes, it's fine to port.

@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Nov 19, 2024
@dvir001
Copy link
Contributor

dvir001 commented Nov 20, 2024

Please do not merge this PR without making changes to min and max,
While I like Cosmatic, the sliders are set to be one of the most LRP parts of the server with super small to extremely large.

image
image

@Lyndomen
Copy link
Contributor Author

Please do not merge this PR without making changes to min and max, While I like Cosmatic, the sliders are set to be one of the most LRP parts of the server with super small to extremely large.

Heard and agreed. I was thinking of only permitting sizes to be +/- 10% default species size, so a max of 20% between the tallest and shortest member of the same species.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Documentation Changes any xml or md files labels Nov 21, 2024
@dffdff2423
Copy link
Contributor

Hello,

I am the original author of this. I strongly recommend that you remove all CD migrations and re-generate your own. This will likely reduce the size of this PR by at least 10k lines of code. They are needed on CD because the original DB model was not very good due to my inexperience with database work. I would also strongly recommend that you make sure the model fits with what DV is doing and rename the cdprofile table accordingly (or merge it with the equivalent DV table).

Hope this helps

@dffdff2423
Copy link
Contributor

Their actual height slider intentionally doesn't change hotboxes, it's fine to port.

If I remember correctly it can make it harder to leftclick swing on people but I am not 100% sure about that.

@dffdff2423
Copy link
Contributor

I'd rather not have heights
particularly cause hitboxes and all, though I wooould like for bitz' height of 3'11" to be reflected i'd rather also not just have the game become be "small size to be hard to hit"
Records though GIVE GIVE ME THEM NOW

Height is just a text field it doesn't do that

Yep, the height in records was intentionally separated from the slider because players may want to have height values that we don't support on the slider.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: UI Changes: YML Changes any yml files S: Merge Conflict Fix your PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants