Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailposter #2239

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Mailposter #2239

merged 3 commits into from
Nov 19, 2024

Conversation

Kr8art
Copy link
Contributor

@Kr8art Kr8art commented Nov 19, 2024

About the PR

Adds a new mail-themed poster. First PR, please don't hurt me.

Why / Balance

Flavour, wanted to learn how to do a PR, no balance implications (also Lyndo told me to do this).

Technical details

  • Added a new folder with the meta/image in the DeltaV textures folder
  • Created new entity in the poster.yml
  • Added the poster id to the random poster spawner list (with comment)

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

n/a

Changelog
🆑

  • add: New mail-themed poster!

@Kr8art Kr8art requested review from IamVelcroboy and a team as code owners November 19, 2024 15:39
@github-actions github-actions bot added Status: Needs Review Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

RSI Diff Bot; head commit 9445061 merging into a495efa
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Structures/Wallmounts/Posters/mailposter.rsi

State Old New Status
mailposter Added

Edit: diff updated after 9445061

@dvir001
Copy link
Contributor

dvir001 commented Nov 19, 2024

MAIL UP

@Lyndomen
Copy link
Contributor

This looks great, nice job!

@MilonPL
Copy link
Member

MilonPL commented Nov 19, 2024

BASED

Copy link
Member

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick, looks good otherwise

@Kr8art
Copy link
Contributor Author

Kr8art commented Nov 19, 2024

Removed capitalization in foldername and poster.yml

@Tomce795
Copy link
Contributor

Don't do a me and forget to request a review for the changes again. Otherwise Milon with forgor :blunt: Click the extra options on the "MilonPL requested changes" thingy and select "request review" or something along those lines.

@Kr8art Kr8art requested a review from MilonPL November 19, 2024 17:04
@Kr8art
Copy link
Contributor Author

Kr8art commented Nov 19, 2024

Don't do a me and forget to request a review for the changes again. Otherwise Milon with forgor :blunt: Click the extra options on the "MilonPL requested changes" thingy and select "request review" or something along those lines.

Yeah, I totally knew I had to do that 😅

@MilonPL MilonPL enabled auto-merge (squash) November 19, 2024 17:10
@MilonPL MilonPL merged commit a4e94f2 into DeltaV-Station:master Nov 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants