Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE Tail Wagging (Real) #2241

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Unkn0wnGh0st333
Copy link
Contributor

@Unkn0wnGh0st333 Unkn0wnGh0st333 commented Nov 19, 2024

About the PR

Ports Einstein Engine's Vulpkanin Tail Wagging & Vulpkanin custom screams.

Why / Balance

Wagging tail on command will be the new stunmeta since everyone will be so scared of your aura when your tail stops wagging

Technical details

  • Einstein-Engine Tail Wagging System
  • Vulpkanin Custom Screams
  • Vulpkanins have cat tails and ears since Felinids get Vulpkanin ears and tails
  • Felinid Tail Wagging on command

Media

image
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

I'm dead

Changelog
🆑

  • add: Vulpkanins and Felinids can wag (and stop wagging) their tail on command! (Uses the EE system!) (Remember to fix your tails!)
  • add: Ported EE Vulpkanin screams! AAAAAAAA!

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: Audio Changes any audio files labels Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

RSI Diff Bot; head commit 6d1bd7e merging into c084a4f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Mobs/Customization/Felinid/felinid_tails.rsi

State Old New Status
felinid_fluffy_tail_rings Modified
felinid_fluffy_tail_base Added
felinid_fluffy_tail_rings_wag Added

Resources/Textures/Nyanotrasen/Mobs/Customization/felinid_tails.rsi

State Old New Status
basic_bell Modified
basic_bow Modified
basic_tail_stripes_even Modified
basic_tail_stripes_odd Modified
basic_tail_tip Modified
basic_bell_wag Added
basic_bow_wag Added
basic_tail_stripes_even_wag Added
basic_tail_stripes_odd_wag Added
basic_tail_tip_wag Added

Resources/Textures/DeltaV/Mobs/Customization/Vulpkanin/tail_markings.rsi

State Old New Status
corgi Added
dalmatian Added

Resources/Textures/Einstein-Engines/Interface/Actions/wagging.rsi

State Old New Status
icon-on Added
icon Added

Edit: diff updated after 6d1bd7e

@Monotheonist
Copy link
Contributor

Monotheonist commented Nov 20, 2024

Massive W for vulp players.
Also, on the topic of the cat ears / tails, I'm pretty sure the reasoning there was because they fit on felinids, you should probably make sure they work with vulps as well. Otherwise I can envision some real cursed vulps.

@Unkn0wnGh0st333 Unkn0wnGh0st333 marked this pull request as ready for review November 20, 2024 21:28
@Unkn0wnGh0st333 Unkn0wnGh0st333 requested review from IamVelcroboy and a team as code owners November 20, 2024 21:28
Content.Server/Wagging/WaggingSystem.cs Outdated Show resolved Hide resolved
Resources/Prototypes/Actions/types.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Actions/types.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Actions/types.yml Show resolved Hide resolved
@sleepyyapril
Copy link
Contributor

I wonder what commit with message Tail Wagging (Real) does. Or Tail Wagging (Real)? Maybe Tail Wagging (Real) too?

Anyways how does that happen?

@github-actions github-actions bot added the size/L 256-1023 lines label Nov 26, 2024
@Unkn0wnGh0st333
Copy link
Contributor Author

Massive W for vulp players. Also, on the topic of the cat ears / tails, I'm pretty sure the reasoning there was because they fit on felinids, you should probably make sure they work with vulps as well. Otherwise I can envision some real cursed vulps.

I know but this was a week ago but to dismiss your concern. Look at a felinids, look at its pixels, realize it's just a shrunken human sprite, horror takes over your body, realize the tails were originally sprited to fit on humans. Yes the tails fit just fine lol

@Lyndomen
Copy link
Contributor

Direction review, 24 hours

Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprites look great, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants