Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprite For Vulps 101 #2254

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Sprite For Vulps 101 #2254

merged 3 commits into from
Nov 22, 2024

Conversation

Kr8art
Copy link
Contributor

@Kr8art Kr8art commented Nov 21, 2024

About the PR

Added a custom sprite for Lyndo's "Vulpkanin 101" book.

Why / Balance

Questionable life choices.

Technical details

  • Added a book.rsi to DeltaV textures
  • Created a new icon for the book
  • Changed the books.yml of "Vulpkanin 101" to adopt the new icon

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

n/a

Changelog
🆑

  • tweak: Vulpkanin 101 now has a custom icon!

@Kr8art Kr8art requested review from IamVelcroboy and a team as code owners November 21, 2024 15:14
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

RSI Diff Bot; head commit 02d85f2 merging into c3134ee
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Misc/books.rsi

State Old New Status
icon_kiss Added

Edit: diff updated after 02d85f2

@Lyndomen
Copy link
Contributor

hell yeah

@Kr8art Kr8art requested a review from deltanedas November 22, 2024 14:12
@Kr8art
Copy link
Contributor Author

Kr8art commented Nov 22, 2024

Addressed requested changes!

@deltanedas deltanedas merged commit 5ee78fc into DeltaV-Station:master Nov 22, 2024
13 checks passed
@deltanedas
Copy link
Member

youre a secmain vulp arent you, you like arresting tiders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltanedas deltanedas deltanedas approved these changes

@IamVelcroboy IamVelcroboy Awaiting requested review from IamVelcroboy

Assignees
No one assigned
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kr8art @Lyndomen @deltanedas