Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resprites EE corpse dragging sprites. #2255

Merged
merged 7 commits into from
Nov 24, 2024
Merged

Resprites EE corpse dragging sprites. #2255

merged 7 commits into from
Nov 24, 2024

Conversation

dotCatshark
Copy link
Contributor

@dotCatshark dotCatshark commented Nov 21, 2024 •
edited
Loading

About the PR

As title. This exchanges the current EE blood trail sprites produced when you drag a dead/crit person with some slightly modified sprites pulled from Ratwood, a roguetown fork, some that I made based on old sprites from roguetown, and one from classic goonstation. Thank you to whoever made these sprites, though your name is lost to time.

Why / Balance

I think the current one look like one of those really low quality photoshop/krita/clip studio brushes that have a ton of overlap. Me no like. And this looks way gorier.

Technical details

Exchanged dragging-1.png through dragging-5.png with a different version, using the same filenames to avoid having to recode anything whatsoever.

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • tweak: Resprited EE sprites for corpse dragging.

@dotCatshark
John File
2d6b6a8 
Ripped from roguetown who they themselves ripped from lifeweb. Credit to whoever on lifeweb created them (probably Randy)

Signed-off-by: Mina <[email protected]>
@dotCatshark
John File Ep. 2
f8bedf8 
Resprited this one so it looks better with the others

Signed-off-by: Mina <[email protected]>
@dotCatshark
John File Ep. 3
c88b702 
I don't want to talk about it.

Signed-off-by: Mina <[email protected]>
@github-actions github-actions bot added S: Needs Review Changes: Sprite Changes any png or json in an rsi labels Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

RSI Diff Bot; head commit 87b3bca merging into 8646c3a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_EE/Effects/footprints.rsi

State Old New Status
dragging-1 Modified
dragging-2 Modified
dragging-3 Modified
dragging-4 Modified
dragging-5 Modified

Edit: diff updated after 87b3bca

@IAmNotGray
Copy link
Contributor

Saw this stuff on the Discord. I approve.

deltanedas
deltanedas requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the meta.json

@dotCatshark
California compliant update
4843c49 
I hate copyright law. 

Signed-off-by: Minä <[email protected]>
@dotCatshark
Update meta.json
ab06e78 
Have I mentioned I hate copyright law

Signed-off-by: Minä <[email protected]>
@dotCatshark
California compliant update part 2
1112e8a 
Signed-off-by: Minä <[email protected]>
@dotCatshark
Copy link
Contributor Author

update the meta.json

Done.

@github-actions github-actions bot added the size/XS Under 16 lines label Nov 24, 2024
@deltanedas
Copy link
Member

changelog should be a single - tweak change saying the body dragging sprites were resprited
meta.json cover where it was taken from that doesnt need to be in cl, if there are multiple authors for the pr you can do :cl: a, b, c, d to list them

@dotCatshark
Copy link
Contributor Author

meta.json cover where it was taken from that doesnt need to be in cl, if there are multiple authors for the pr you can do :cl: a, b, c, d to list them

Could you please rewrite or otherwise clarify this sentence, I am having difficulty understanding what you're saying.

@deltanedas
Copy link
Member

its fine now just add :cl: and change Tweak to - tweak

@dotCatshark
Copy link
Contributor Author

I understood it. Done now.

@deltanedas deltanedas merged commit c6ef594 into DeltaV-Station:master Nov 24, 2024
11 of 13 checks passed
@dotCatshark dotCatshark deleted the caleb-from-blood-(real) branch November 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltanedas deltanedas deltanedas approved these changes

@IamVelcroboy IamVelcroboy Awaiting requested review from IamVelcroboy

Assignees
No one assigned
Labels
Changes: Sprite Changes any png or json in an rsi S: Needs Review size/XS Under 16 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotCatshark @IAmNotGray @deltanedas