Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bread knife exclusive to perma #2304

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

Radezolid
Copy link
Contributor

About the PR

I wish to add a knife to perma prisoners.
Note: I do not own a bread knife, I looked up some images and did a quick change to the sprites, if ya got a comment on that let me know.

Why / Balance

Discussions about the limitations of a plastic knife vs shiv for perma, so just give them a worse shiv damage-wise but better as a tool.

Technical details

YAML changes.

Media

New knife on the right, compare in size with a regular kitchen knife.
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Nope.

Changelog

🆑

  • add: Added a prisoner's knife, it's purpose is of a tool and it's damage is minimal

@Radezolid Radezolid requested review from IamVelcroboy and a team as code owners November 27, 2024 23:21
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi size/S 16-63 lines labels Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024

RSI Diff Bot; head commit 0f83a82 merging into bf7a8d9
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Melee/prison_knife.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 0f83a82

@deltanedas deltanedas requested a review from a team as a code owner December 17, 2024 04:52
@Lyndomen
Copy link
Contributor

Taking in for direction review.

Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, bread knife

@Lyndomen Lyndomen added the S: Approved Approved direction-wise, pending code review. label Dec 18, 2024
@deltanedas deltanedas merged commit 6391624 into DeltaV-Station:master Dec 19, 2024
20 checks passed
@Radezolid Radezolid deleted the perma-knife branch December 26, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Approved Approved direction-wise, pending code review. S: Needs Review size/S 16-63 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants