Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke core container closed fail popup #2309

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Kr8art
Copy link
Contributor

@Kr8art Kr8art commented Nov 28, 2024

About the PR

Fixes #2173

Why / Balance

To stop syndies from getting confused and dying to radiation.

Technical details

  • edited ftl files to make a new nuke core container specific error message
  • integrated new error message into yaml

Media

NukeCore_demo.mp4

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

n/a

Changelog
🆑

  • fix: The nuke core container now displays an appropriate message when hasty syndicate agents try to insert the nuke core while it is still closed!

@Kr8art Kr8art requested a review from a team as a code owner November 28, 2024 16:40
@github-actions github-actions bot added S: Needs Review size/XS Under 16 lines Changes: YML Changes any yml files Changes: Localization Changes any ftl files and removed size/XS Under 16 lines labels Nov 28, 2024
@Radezolid
Copy link
Contributor

Little tip: You can add "Fixes #2173" to the PR and it will close that issue once it's merged.

@Kr8art
Copy link
Contributor Author

Kr8art commented Nov 28, 2024

Little tip: You can add "Fixes #2173" to the PR and it will close that issue once it's merged.

Does that still work if I edit the original PR?

@Kr8art
Copy link
Contributor Author

Kr8art commented Nov 28, 2024

Looks like it does, I updated both of my PRs.

@deltanedas deltanedas merged commit dac7980 into DeltaV-Station:master Nov 28, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plutonium Core does not fit in the Nuke Core Container
3 participants