Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Maintenance Lights #2465

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Updates Maintenance Lights #2465

merged 2 commits into from
Dec 18, 2024

Conversation

IamVelcroboy
Copy link
Member

About the PR

  • Removes red maints light in favor of new "dim" light
  • Adjusts white maints light to disperse better
  • Makes Nyano-inherited lights cause the same dmg and popup text
  • Fixes #2240

Why / Balance

  • They look better
  • Bug fixes
  • Mapping QoL

Technical details

Might have to adjust some maps but won't be a major issue for the most part.

Media

Before
Screenshot 2024-12-17 204336
Screenshot 2024-12-17 204340

After
Screenshot 2024-12-17 204347
Screenshot 2024-12-17 204355

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an in-game showcase.

Breaking changes

n/a

@IamVelcroboy IamVelcroboy requested a review from a team as a code owner December 18, 2024 02:48
@github-actions github-actions bot added S: Needs Review size/M 64-255 lines Changes: YML Changes any yml files labels Dec 18, 2024
@deltanedas
1 char typo
ba7072c 
Signed-off-by: deltanedas <[email protected]>
@deltanedas deltanedas enabled auto-merge (squash) December 18, 2024 04:00
@deltanedas deltanedas merged commit 2623935 into DeltaV-Station:master Dec 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltanedas deltanedas deltanedas approved these changes

Assignees
No one assigned
Labels
Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DV/Nyano based lights need to display properly while mapping. [Beginner Friendly]
3 participants
@IamVelcroboy @deltanedas @BurningRash