Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port ore bag magnet toggle from white dream #2467

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

deltanedas
Copy link
Member

About the PR

ore bags magnet is now a toggle instead of only if you equip it in your belt slot
this means mining borgs can now use ore magnet

Why / Balance

insane QOL for mining borgs and salvage in general

Technical details

  • added ItemToggleExamine, surprised it didnt exist already

Media

off:
05:22:56

on:
05:23:03

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

no

Changelog
🆑 Hell_Cat, deltanedas

  • tweak: Ore bag magnet can now be turned on without being worn as a belt. Mining borgs rejoice!

@deltanedas deltanedas requested review from a team as code owners December 18, 2024 05:29
@github-actions github-actions bot added size/M 64-255 lines S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an rsi labels Dec 18, 2024
Copy link
Contributor

RSI Diff Bot; head commit 13477fb merging into 2623935
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Mining/ore_bag.rsi

State Old New Status
icon_on Added

Resources/Textures/Objects/Specific/Mining/ore_bag_holding.rsi

State Old New Status
icon_on Added

@deltanedas deltanedas merged commit dce230f into master Dec 18, 2024
21 checks passed
@deltanedas deltanedas deleted the ore-bag-magnet-ops branch December 18, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant