-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Detective Drip #2472
base: master
Are you sure you want to change the base?
Return Detective Drip #2472
Conversation
Signed-off-by: rosieposie <[email protected]>
you are also getting a bonus Accidentally Removed A Space on a random loadout file. just one of the many perks of my githubs contribution's. |
Should have added a non-armored variant for the costume drobes 😔 |
- id: ClothingHeadHatFedoraBrown # DeltaV | ||
- id: ClothingNeckTieDet # DeltaV | ||
- id: ClothingOuterVestDetective # DeltaV | ||
- id: ClothingOuterCoatDetective # DeltaV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't need # DeltaV comment as its being reverted to how it is upstream
ClothingShoesColorBrown: 2 # DeltaV | ||
ClothingOuterCoatDetectiveLoadout: 2 # DeltaV | ||
ClothingHeadHatFedoraBrown: 2 # DeltaV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't need # DeltaV comment as its being reverted to how it is upstream
ClothingOuterVestDetective: 2 # DeltaV | ||
ClothingNeckTieDet: 2 # DeltaV | ||
ClothingHeadHatFedoraGrey: 2 # DeltaV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't need # DeltaV comment as its being reverted to how it is upstream
ClothingOuterCoatDetectiveLoadout: 2 # DeltaV | ||
ClothingHeadHatFedoraBrown: 2 # DeltaV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth noting that these have quantity 1 upstream add a # DeltaV comment denoting such a change if we are keeping it to 2
- type: Armor #same as regular sec armor | ||
modifiers: | ||
coefficients: | ||
Blunt: 0.70 | ||
Slash: 0.70 | ||
Piercing: 0.70 | ||
Heat: 0.80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary to add as it is parenting off of ClothingOuterCoatDetective
- DetectiveFedora # DeltaV - removed for incongruence | ||
- DetectiveFedoraGrey # DeltaV - removed for incongruence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove # DeltaV comment
@@ -386,7 +386,7 @@ | |||
- SecurityShoes | |||
- SurvivalSecurity | |||
- Trinkets | |||
- SecurityStar | |||
- SecurityStar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't make unrelated changes in upstream files as it makes it harder to merge. make a separate pr upstream for this
- DetectiveArmorVest # DeltaV | ||
- DetectiveCoat # DeltaV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't need # DeltaV comment as its being reverted to how it is upstream
The trenchcoat does fit well with the anachronistic athesthetic but I worry it being armoured would encourage valid hunting. |
if dets want armour they can get armour very easily and secs job is to validhunt, det ignoring comms doesnt change because they have armour or not |
every secoff already has armor, including the detective, who has an armored coat i just dont prefer the look of |
ah that's fair then |
About the PR
Gives the detective back their trenchcoat, vest, fedora, tie, shoes, etc in the detdrobe, as well as removes the coat from the repdrobe as it is now armored again. Adds stuff back into the loadouts as well.
Detectives without the old coat look identical to every other sec officer, and the new coat is... just strange. I like playing as a detective in the cheesy old timey coat or vest. Its fun. Can we have fun? I want to have fun.
Media
Requirements
Changelog
🆑