Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Detective Drip #2472

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rosieposieeee
Copy link
Contributor

About the PR

Gives the detective back their trenchcoat, vest, fedora, tie, shoes, etc in the detdrobe, as well as removes the coat from the repdrobe as it is now armored again. Adds stuff back into the loadouts as well.

Detectives without the old coat look identical to every other sec officer, and the new coat is... just strange. I like playing as a detective in the cheesy old timey coat or vest. Its fun. Can we have fun? I want to have fun.

Media

Content Client_7uGIDXsfwY

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Changelog
🆑

  • tweak: Detectives now have their cool coat and vest again.

@rosieposieeee rosieposieeee requested a review from a team as a code owner December 18, 2024 10:05
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files size/S 16-63 lines and removed S: Needs Review labels Dec 18, 2024
Signed-off-by: rosieposie <[email protected]>
@rosieposieeee
Copy link
Contributor Author

you are also getting a bonus Accidentally Removed A Space on a random loadout file. just one of the many perks of my githubs contribution's.

@Unkn0wnGh0st333
Copy link
Contributor

Should have added a non-armored variant for the costume drobes 😔
But besides that yes, awesome PR

Comment on lines +190 to +193
- id: ClothingHeadHatFedoraBrown # DeltaV
- id: ClothingNeckTieDet # DeltaV
- id: ClothingOuterVestDetective # DeltaV
- id: ClothingOuterCoatDetective # DeltaV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need # DeltaV comment as its being reverted to how it is upstream

Comment on lines +6 to +8
ClothingShoesColorBrown: 2 # DeltaV
ClothingOuterCoatDetectiveLoadout: 2 # DeltaV
ClothingHeadHatFedoraBrown: 2 # DeltaV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need # DeltaV comment as its being reverted to how it is upstream

Comment on lines +11 to +13
ClothingOuterVestDetective: 2 # DeltaV
ClothingNeckTieDet: 2 # DeltaV
ClothingHeadHatFedoraGrey: 2 # DeltaV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need # DeltaV comment as its being reverted to how it is upstream

Comment on lines +7 to +8
ClothingOuterCoatDetectiveLoadout: 2 # DeltaV
ClothingHeadHatFedoraBrown: 2 # DeltaV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that these have quantity 1 upstream add a # DeltaV comment denoting such a change if we are keeping it to 2

Comment on lines +42 to +48
- type: Armor #same as regular sec armor
modifiers:
coefficients:
Blunt: 0.70
Slash: 0.70
Piercing: 0.70
Heat: 0.80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary to add as it is parenting off of ClothingOuterCoatDetective

Comment on lines +1257 to +1258
- DetectiveFedora # DeltaV - removed for incongruence
- DetectiveFedoraGrey # DeltaV - removed for incongruence
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove # DeltaV comment

@@ -386,7 +386,7 @@
- SecurityShoes
- SurvivalSecurity
- Trinkets
- SecurityStar
- SecurityStar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't make unrelated changes in upstream files as it makes it harder to merge. make a separate pr upstream for this

Comment on lines +1287 to +1288
- DetectiveArmorVest # DeltaV
- DetectiveCoat # DeltaV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need # DeltaV comment as its being reverted to how it is upstream

@ewokswagger
Copy link
Contributor

The trenchcoat does fit well with the anachronistic athesthetic but I worry it being armoured would encourage valid hunting.

@deltanedas
Copy link
Member

if dets want armour they can get armour very easily

and secs job is to validhunt, det ignoring comms doesnt change because they have armour or not

@rosieposieeee
Copy link
Contributor Author

every secoff already has armor, including the detective, who has an armored coat i just dont prefer the look of

@ewokswagger
Copy link
Contributor

ah that's fair then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files size/S 16-63 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants