Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vent critters rework #2495

Merged
merged 5 commits into from
Dec 23, 2024
Merged

vent critters rework #2495

merged 5 commits into from
Dec 23, 2024

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Dec 21, 2024

About the PR

actually didnt take that long didnt need the nuking pr at all :trollface:

this makes vent critters better for everyone, sec and crew alike:

  • 1 vent is picked for all mobs to spawn from
  • the station gets 30 seconds advance warning before they spawn, giving crew time to run away and sec to arm up
  • number of critters scales with player count so lowpop doesnt get as many as highpop
  • false alarm, its just mice!!!

current numbers can go up to like 9 slimes on highpop, requiring good sec coordination to deal with

Why / Balance

makes vent critters less ass and more fair to new players that dont have a spear ready to not get killed by simplemobs
now that you can run away, sec actually has something to do instead of "oops the crew killed all the simplemobs to not fucking die, just run around looking for stragglers in unlit maints"

Technical details

vent critters rule was completely rewritten :trollface:

Media

so real
08:31:59

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

any future vent critter events will need duration lowered to 30

Changelog
🆑

  • tweak: Reworked vent critters, now after a 30 second delay all the mobs spawn from 1 vent from the announcement.

@deltanedas deltanedas requested review from a team as code owners December 21, 2024 09:26
@github-actions github-actions bot added size/M 64-255 lines S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files and removed S: Needs Review labels Dec 21, 2024
@ThataKat
Copy link
Contributor

Direction reviewing, answer in 1-2 days

@rosieposieeee
Copy link
Contributor

a little concerned 15s might be way too little time, maybe something more like 45s? i can imagine using up all 15s just trying to tell someone that we need to leave, and sec wont even have a chance to respond in 15s

@deltanedas
Copy link
Member Author

sec doesnt need to teleport there, as long as everyone is out of harms way the slimes spiders etc will stay there patiently waiting for sec to arrive

Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction requesting 30 second advance warning. theres some concerns about this making sec go to insta-red and unleash the armory, but kinda IC issue.

We also got good feedback that other mobs being included would be cool, idk cat flood or something. We can WYCI that later if we like it

@deltanedas deltanedas merged commit 9beaf06 into master Dec 23, 2024
10 checks passed
@deltanedas deltanedas deleted the vent-rework-ops branch December 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants