Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research digiboard #2508

Merged
merged 16 commits into from
Dec 26, 2024
Merged

Research digiboard #2508

merged 16 commits into from
Dec 26, 2024

Conversation

SirSmith148
Copy link
Contributor

@SirSmith148 SirSmith148 commented Dec 22, 2024 •
edited
Loading

About the PR

Added New Mystagogue item, the Research Digi-Board, this work similarly to the Logistics Digi-Board, allowing remote use of the research console. (Link to Pull request of original Digi-board: abaa2fe#diff-6e493dfa3320562d461bc23a070f671cfd6e2f55574c8de3a5c9ea6ed6799bffR557)

Why / Balance

The Logistics Officer and the Mystagogue have the unique gameplay loop of needing to take requests from the crew for certain items/research, and then using a console to order or approve. Giving the Mysta the ability for it will allow them to fulfill these requests when otherwise busy handling anoms or deep inside the research labs of epi, and when understaffed.

Technical details

-Added code for opening the research menu with the Digi-Board
-Added new Digi-Board to antag steal objective lists
-Added new Digi-Board to Mysta Locker list

Media

Just a recolor of the original Digi-Board Sprite
https://imgur.com/a/1kCcJDx

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

N/A

Changelog

🆑

  • add: Research Digi-Board
  • tweak: Added Research Digi-Board to Steal Objectives

@SirSmith148 SirSmith148 requested review from a team as code owners December 22, 2024 06:06
@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi S: Needs Review size/M 64-255 lines labels Dec 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2024 •
edited
Loading

RSI Diff Bot; head commit 45d711b merging into 91bc1b3
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Misc/rd_clipboard.rsi

State Old New Status
equipped-BELT Added
inhand-left Added
inhand-right Added
rd_clipboard Added
rd_clipboard_over Added
rd_clipboard_paper Added
rd_clipboard_pen Added

Edit: diff updated after 45d711b

deltanedas
deltanedas requested changes Dec 22, 2024
View reviewed changes
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these need to go in deltav folders

@SirSmith148 SirSmith148 reopened this Dec 22, 2024
@deltanedas
Copy link
Member

you dont have to close it or anything just push commits to the same branch

@SirSmith148
Copy link
Contributor Author

you dont have to close it or anything just push commits to the same branch

It was a mis click sorry haha, I only really edited existing files, do I need to migrate the whole files I edited to the DeltaV folder?

@deltanedas
Copy link
Member

yes

@SirSmith148
Moved New Files To DeltaV Folder
888ca3f 
Files were moved to Delta V, except objectiveGroups. And updated sprites
@SirSmith148
Copy link
Contributor Author

yes

Updated was able to move everything to Delta V except the ObjectiveGroups as I saw all the other DeltaV ones were in the original file

deltanedas
deltanedas requested changes Dec 22, 2024
View reviewed changes
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that, just waiting on direction approval

Resources/Textures/DeltaV/Objects/Misc/rd_clipboard.rsi/meta.json Outdated Show resolved Hide resolved
@Lyndomen
Copy link
Contributor

Hello! Direction review, 24 hours.

@SirSmith148
Copy link
Contributor Author

Hello! Direction review, 24 hours.

Thank you!

deltanedas
deltanedas previously approved these changes Dec 23, 2024
View reviewed changes
Lyndomen
Lyndomen requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting an update to move this down to about 7 or 8 blunt, not 10. Once that is all set, approved!

@SirSmith148
Copy link
Contributor Author

Requesting an update to move this down to about 7 or 8 blunt, not 10. Once that is all set, approved!

Its the same amount of blunt as the logistics version not that it really matters to me lol

@SirSmith148 SirSmith148 requested a review from Lyndomen December 23, 2024 22:53
@deltanedas deltanedas merged commit 9127a87 into DeltaV-Station:master Dec 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lyndomen Lyndomen Lyndomen approved these changes

@deltanedas deltanedas deltanedas left review comments

Assignees
No one assigned
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SirSmith148 @deltanedas @Lyndomen