Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security resprite final cut #2695

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

TadJohnson00
Copy link
Contributor

@TadJohnson00 TadJohnson00 commented Jan 11, 2025

About the PR

This PR adjusts the majority of the remaining Security-related sprites to fit the planned rebranding and aesthetic. This includes the following:

  • Security backpacks, satchels, and duffel bags
  • Forensic gloves
  • The holobarrier projector
  • The security radio
  • The security whistle
  • Security bedsheets
  • Security PDAs, ID cards, and job icons
  • The security banner
  • The armoury and security techfabs
  • The SecDrobe, DetDrobe, and SecTech vending machines
  • Security lockers and crates
  • Security directional and departmental signs
  • Security jetpacks
  • Security airlocks

I guess you could call this a Quickfix.

Why / Balance

A lot of entities, such as the airlocks, signs, and banners, do not fit security's intended aesthetic or theme. As such, this PR addresses that issue and adjusts the sprites of these entities accordingly. While this is the reason why most items were adjusted, some small tweaks were made to other sprites for the purpose of improving quality also.

Technical details

n/a

Media

image
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • tweak: NanoTrasen Station Security have received another rollout of new uniform apparel, and various stations are in the process of renovating their Security departments; be careful of leaning against freshly painted airlocks especially in freshly issued gear.

@github-actions github-actions bot added the size/M 64-255 lines label Jan 11, 2025
@TadJohnson00 TadJohnson00 changed the title turn security gey turn security grey Jan 11, 2025
@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Jan 11, 2025
Copy link
Contributor

github-actions bot commented Jan 11, 2025

RSI Diff Bot; head commit 28dc6a2 merging into 3472522
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Interface/Misc/job_icons.rsi

State Old New Status
SecurityBorg Modified
nyanoPrisonGuard Modified
Brigmedic Added
Detective Added
SecurityCadet Added
SecurityOfficer Added
SeniorOfficer Added
Warden Added

Resources/Textures/_DV/Objects/Devices/pda.rsi

State Old New Status
pda-corpsman Modified
pda-detective Modified
pda-hos Modified
pda-interncadet Modified
pda-prisonguard Modified
pda-security Modified
pda-seniorofficer Modified
pda-warden Modified

Resources/Textures/_DV/Objects/Misc/id_cards.rsi

State Old New Status
nyanoprisonguard Modified
default Added
idbrigmedic Added
iddetective Added
idheadofsecurity Added
idintern-cadet Added
idsecurityofficer Added
idseniorofficer Added
idwarden Added
silver Added

Resources/Textures/_DV/Objects/Tanks/Jetpacks/security.rsi

State Old New Status
equipped-BACKPACK Modified
equipped-SUITSTORAGE Modified
icon-on Modified
icon Modified
inhand-left Modified
inhand-right Modified
on-equipped-BACKPACK Modified
on-equipped-SUITSTORAGE Modified

Resources/Textures/_DV/Structures/Doors/Airlocks/Glass/security.rsi

State Old New Status
assembly Modified
closed Modified
closing Modified
open Modified
opening Modified

Resources/Textures/_DV/Structures/Doors/Airlocks/Standard/security.rsi

State Old New Status
assembly Modified
closed Modified
closing Modified
open Modified
opening Modified

Resources/Textures/_DV/Clothing/Back/Backpacks/security.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Clothing/Back/Duffels/security.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Clothing/Back/Satchels/security.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Clothing/Hands/Gloves/forensic.rsi

State Old New Status
equipped-HAND Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Objects/Devices/Holoprojectors/security.rsi

State Old New Status
icon Added

Resources/Textures/_DV/Objects/Devices/securityhandy.rsi

State Old New Status
walkietalkie-off Added
walkietalkie-on Added
walkietalkie Added

Resources/Textures/_DV/Objects/Misc/bedsheets.rsi

State Old New Status
sheetbrigmedic Added
sheetdet Added
sheethos Added
sheetwarden Added

Resources/Textures/_DV/Structures/Decoration/banner.rsi

State Old New Status
banner_security Added

Resources/Textures/_DV/Structures/Machines/VendingMachines/detdrobe.rsi

State Old New Status
broken Added
normal-unshaded Added
off Added
panel Added

Resources/Textures/_DV/Structures/Machines/VendingMachines/sec.rsi

State Old New Status
broken Added
deny-unshaded Added
eject-unshaded Added
normal-unshaded Added
off Added
panel Added

Resources/Textures/_DV/Structures/Machines/VendingMachines/secdrobe.rsi

State Old New Status
broken Added
normal-unshaded Added
off Added
panel Added

Resources/Textures/_DV/Structures/Machines/techfab.rsi

State Old New Status
ammo Added
icon Added
inserting Added
panel Added
sec Added
unlit Added

Resources/Textures/_DV/Structures/Storage/Crates/sec_gear.rsi

State Old New Status
base Added
closed Added
icon Added
locked Added
open Added
sparking Added
unlocked Added
welded Added

Resources/Textures/_DV/Structures/Storage/closet.rsi

State Old New Status
armory Added
armory_door Added
armory_open Added
brigmedic Added
brigmedic_door Added
brigmedic_open Added
det Added
det_door Added
det_open Added
evidence Added
evidence_door Added
evidence_open Added
hos Added
hos_door Added
hos_open Added
sec Added
sec_door Added
sec_open Added
warden Added
warden_door Added
warden_open Added

Resources/Textures/_DV/Structures/Wallmounts/signs.rsi

State Old New Status
armory Added
direction_brig Added
direction_sec Added
interrogation Added
law Added
prison Added
sec Added
security Added

Edit: diff updated after 28dc6a2

@Bonktrauma
Copy link
Contributor

Why

@TadJohnson00
Copy link
Contributor Author

TadJohnson00 commented Jan 11, 2025

= cohesion and congruency
= server identity
= abolition of trope
= better sprites (biased)
+ more

@TadJohnson00 TadJohnson00 changed the title turn security grey Security resprite final cut Jan 11, 2025
@TadJohnson00 TadJohnson00 marked this pull request as ready for review January 11, 2025 13:03
@TadJohnson00 TadJohnson00 requested review from a team as code owners January 11, 2025 13:03
@Bonktrauma
Copy link
Contributor

= cohesion and congruency
= server identity
= abolition of trope
= better sprites (biased)
+ more

Sounds good

@Avalon-Proto
Copy link
Contributor

Okay I will admit. While I do miss the idea of red/blue sec, these sprites are quite nice. Though. What's the Locker with an E? Just a new one?

@Lyndomen
Copy link
Contributor

Fastest work in the West wtf

@TadJohnson00
Copy link
Contributor Author

Okay I will admit. While I do miss the idea of red/blue sec, these sprites are quite nice. Though. What's the Locker with an E? Just a new one?

E for markiplier evidence

@HTMLSystem
Copy link
Contributor

These sprites look so fucking good. Though I wish the foresic gloves had some type of color at the end of them (maybe like a grey or red) because they look a lil like regular black gloves? But other than that these look fantastic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants