-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port undergarments from ImpStation #2719
Conversation
RSI Diff Bot; head commit f6c4ad3 merging into d9baf11 Resources/Textures/_DV/Mobs/Customization/tattoos.rsi
Resources/Textures/_Impstation/Mobs/Customization/undershirt.rsi
Resources/Textures/_Impstation/Mobs/Customization/underwear.rsi
|
5a1cf0b
to
e493f1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review time!
Any files that are actually from imp station place them in their folder _Impstation
Resources/Prototypes/_DV/Entities/Mobs/Customization/Markings/undershirt.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_DV/Entities/Mobs/Customization/Markings/underwear.yml
Outdated
Show resolved
Hide resolved
Resources/Textures/_DV/Mobs/Customization/tattoos.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_DV/Mobs/Customization/undershirt.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_DV/Mobs/Customization/underwear.rsi/meta.json
Outdated
Show resolved
Hide resolved
space-wizards/space-station-14#33185 |
e493f1c
to
35dc11e
Compare
Interesting. However, I feel that it makes some changes that are out of scope, at least for my own priorities in implementing this change. |
35dc11e
to
f7bd4f6
Compare
Done! |
ahahaha whoops forgot to update file paths hang on :elp: |
f7bd4f6
to
77fff36
Compare
THERE we go |
77fff36
to
ce5a2a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lack permits as of right now, so I'll notify direction via discord.
ce5a2a9
to
40ff0cc
Compare
to expand on this, i'm also not a fan of a toggle changing how other players' characters look without their input. is this a rational distaste? idk. but i don't like the vibe |
hey heads up that this is a port of space-wizards/space-station-14#31221. pinkbat5 brought it to impstation and modified the sprites but the code is originally from a upstream PR. sorry about our poor attribution from our earlier features, we didnt have standards for a while edit: foldablecomponent is also originally from a closed or in limbo upstream PR, im asking airfryer to source it properly |
noted. does this necessitate any changes to the contents of the PR? |
nope, you're all good, i just wanted to make sure we werent being mistakenly credited for code we didnt work on |
40ff0cc
to
dc0c909
Compare
@Radezolid join the team you were invited to |
Lmao, didn't get the notification, thanks. |
dc0c909
to
314a4f6
Compare
Direction is reviewing, get back to you in about a day! |
314a4f6
to
d6e9b71
Compare
All races available in the character creator may wear undergarments. Also lets slimefolk wear chest tattoos.
d6e9b71
to
f6c4ad3
Compare
Direction approval! Go ahead and hit it! |
All races available in the character creator may wear undergarments.
Also lets slimefolk wear chest tattoos.
About the PR
Ports the undergarment markings from ImpStation.
A pretty direct port of impstation/imp-station-14#384.
EDIT: Actually a port of space-wizards/space-station-14#31221 by way of the above.
Why / Balance
With the recent addition of surgery, characters have to be stripped much more frequently than used to be the case.
This change helps preserve some dignity.
Additionally, it just allows for a little bit more RP flavor and variety in how characters present. And it will tie in nicely with the ability to tie jumpsuit jackets around your waist once I port impstation/imp-station-14#375.
Technical details
Markings. So many markings. Almost all YAML and locale files except for, like,
twosix lines of C#.Media
Requirements
Breaking changes
To my knowledge there are no breaking changes. Two enums gain new fields, but this seems to not pose any issues (unless something is relying on enum variants' numerical indicies, which I'm pretty sure isn't really a thing in C#).
Changelog
🆑