-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent crafting of the Clown Hardsuit #360
Merged
Colin-Tel
merged 2 commits into
DeltaV-Station:master
from
FluffiestFloof:removetheclownevahardsuit
Oct 30, 2023
Merged
Prevent crafting of the Clown Hardsuit #360
Colin-Tel
merged 2 commits into
DeltaV-Station:master
from
FluffiestFloof:removetheclownevahardsuit
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cdb10ae.
Colin-Tel
approved these changes
Oct 30, 2023
DeltaV-Bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 3, 2025
## Mirror of PR #26263: [Add stealthmins](space-wizards/space-station-14#26263) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `dca0c6694bce56fcf962feab2b59ad4a849f4533` PR opened by <img src="https://avatars.githubusercontent.com/u/32041239?v=4" width="16"/><a href="https://github.com/nikthechampiongr"> nikthechampiongr</a> at 2024-03-19 16:14:22 UTC --- PR changed 11 files with 197 additions and 10 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > resolve #26013 > > ## About the PR > <!-- What did you change in this PR? --> > This pr implements stealthmins as laid out in issue #26013. > > There is now the Stealth permission flag. This allows admins to use the stealthmin command and to see other stealthmins. > > When stealthmin is toggled, the admin will not show up in adminwho except for other admins with the Stealth permission. > > The stealthmin command sends fake de-admin/re-admin messages to admins without the Stealth flag. > > stealthmin persists in the same way deadmin does(it persists for the lifetime of the server). > > Admin login/logout messages are suppressed for stealthmins except for other admins with the Stealth flag. > > It is still possible possible to find stealthed admins using toolshed commands or logs. This is in line with the requirements of the issue, and I don't want to start clobbering functionality of logs and toolshed. > > ## Why / Balance > > See #26013 > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > Stealth flag now exist for AdminFlags. > > An admin's stealth status is saved in their admin registration and in ContentData. > > SendAdminAnnouncement now takes a whitelist flag and blacklist flag (This will work with multiple flags). This is necessary to suppress admin announcements where necessary. Blacklist takes priority over whitelist. > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > https://github.com/space-wizards/space-station-14/assets/32041239/98ec48c3-170e-406a-b177-07003ff7d59f > > > - [x] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > 🆑 > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > > 🆑 > ADMIN: > - add: The stealthmin command has been added. Admins with the Stealth permission can now hide themselves from adminwho except for other admins with that permission. </details> --------- Signed-off-by: DEATHB4DEFEAT <[email protected]> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <[email protected]> Co-authored-by: DEATHB4DEFEAT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Reverts the previous changes to make it more EVA like and prevents it from being craftable.
Why / Balance
As per discussion with Leo.
Prevents it from existing in game outside of mapper/admin spawn.
Technical details
Media
Breaking changes
Changelog
🆑