Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nyano port of digging #400

Merged
merged 18 commits into from
Dec 6, 2023
Merged

Nyano port of digging #400

merged 18 commits into from
Dec 6, 2023

Conversation

Ygg01
Copy link
Contributor

@Ygg01 Ygg01 commented Nov 5, 2023

About the PR

Ports Nyano digging.

Why / Balance

Was asked to do it.

Media

Digging a dirt tile to bedrock.

Digging Preview

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Closes #386

Changelog
🆑

  • add: Digging dirt.

@github-actions github-actions bot added S: Needs Review Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Nov 5, 2023
@Ygg01 Ygg01 marked this pull request as draft November 5, 2023 15:02
@Ygg01
Copy link
Contributor Author

Ygg01 commented Nov 5, 2023

It's digging right into the Errors Layer

Content Client_9VIKFKBRiG

@deltanedas
Copy link
Member

if you dont rock and stone you aint coming home

@Ygg01
Copy link
Contributor Author

Ygg01 commented Nov 5, 2023

if you dont rock and stone you aint coming home

Did I hear a Rock and Stone?

@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an rsi label Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

RSI Diff Bot; head commit 09ddf5e merging into 14c7ba4
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Nyanotrasen/Objects/Tiles/tiles.rsi

State Old New Status
bedrock-inhand-left Added
bedrock-inhand-right Added
bedrock Added
dirt-inhand-left Added
dirt-inhand-right Added
dirt Added
grassdark-inhand-left Added
grassdark-inhand-right Added
grassdark Added
grassjungle-inhand-left Added
grassjungle-inhand-right Added
grasslight-inhand-left Added
grasslight-inhand-right Added
grasslight Added

Edit: diff updated after 09ddf5e

@Ygg01 Ygg01 marked this pull request as ready for review November 11, 2023 22:56
@DebugOk
Copy link
Contributor

DebugOk commented Nov 27, 2023

@DebugOk remember to review this :clueless:

@Ygg01
Copy link
Contributor Author

Ygg01 commented Dec 2, 2023

@DebugOk did you forget :P ?

Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good enough. I'm sure people will complain if it doesnt work

@DebugOk DebugOk merged commit 089398d into DeltaV-Station:master Dec 6, 2023
12 checks passed
DeltaV-Bot pushed a commit that referenced this pull request Dec 6, 2023
@Ygg01 Ygg01 deleted the digging branch December 12, 2023 18:52
DebugOk pushed a commit to DebugOk/Delta-v that referenced this pull request Jan 20, 2024
* Velcroboy changes

* Fix compilation errors

* Fix borked path

* Fix

* Moved to shared, fixed some problems with code

* Cleanup

* Fix paths

* Fix

* Move files around

* Moved DiggingSystem to Server

(cherry picked from commit 089398d)
DebugOk pushed a commit to DebugOk/Delta-v that referenced this pull request Jan 20, 2024
NullWanderer added a commit to NullWanderer/Delta-v that referenced this pull request Jul 1, 2024
deltanedas pushed a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subfloor/digging ported from Nyano
3 participants