Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mouse Ops #403

Closed
wants to merge 28 commits into from
Closed

Added Mouse Ops #403

wants to merge 28 commits into from

Conversation

ps3moira
Copy link
Contributor

@ps3moira ps3moira commented Nov 5, 2023

Mouse Operator reinforcements are new little buddies to help out with Syndicate goals.

About the PR

Added Mouse Operatives and a Mouse-Op Reinforcement Radio to the Syndicate Uplink

Why / Balance

Added this because Mouse-Ops can aid with their unique size and ability to Syndicate's while also being very affordable.

Media

https://www.youtube.com/watch?v=ybHq5ovoqsk

Screenshot 2023-11-05 142453

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • add: Added mouse operative reinforcements, which can be bought from the Syndicate uplink

Mouse Operator reinforcements are new little buddies to help out with Syndicate goals.
@github-actions github-actions bot added S: Needs Review Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Nov 5, 2023
Copy link
Contributor

github-actions bot commented Nov 5, 2023

RSI Diff Bot; head commit b670ccb merging into 5333a89
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Mobs/Animals/nukiemouse.rsi

State Old New Status
dead Added
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added
mouse Added
splat Added

Resources/Textures/DeltaV/Objects/Devices/communication.rsi

State Old New Status
cheese-radio Added

Edit: diff updated after b670ccb

@ps3moira ps3moira marked this pull request as draft November 5, 2023 20:01
@deltanedas
Copy link
Member

replace radio with cheese wedge

@ps3moira
Copy link
Contributor Author

ps3moira commented Nov 5, 2023

replace radio with cheese wedge

I'll make a sprite for a cheese wedge with a tiny radio antenna sticking out or something lol

@Adrian16199
Copy link
Contributor

Imagine gettin this and a zombie kit, dear god.

@VMSolidus
Copy link
Contributor

Holy shit this is amazing, I LOVE IT

@ps3moira ps3moira marked this pull request as ready for review November 5, 2023 22:09
@deltanedas
Copy link
Member

besides being given microbombs and eating, what can they do

@ps3moira
Copy link
Contributor Author

ps3moira commented Nov 5, 2023

besides being given microbombs and eating, what can they do

I made a little video but basically.

They can have C4 planted on them, insulated so they can chew wires, their suit protects them from space so they can survive spacings, they can talk (not that they can really say much besides squeak) on the Syndicate channel and get orders from the Syndicate channel, and they can do pretty anything a mouse can do while also able to attack/pull things and have a slight armor/damage boost.

@ps3moira ps3moira requested a review from DebugOk November 5, 2023 22:28
@deltanedas
Copy link
Member

real

Copy link
Contributor Author

@ps3moira ps3moira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the parts from Locale into the DeltaV folder

@DEATHB4DEFEAT
Copy link
Member

Changelog
🆑

  • add: Added Mouse-Ops
  • add: Added Mouse-Ops Reinforcement Radio
  • add: Added Mouse-Ops Reinforcement Radio to Uplink

Why are there three CLs?

  • add: Added mouse operative reinforcements, which can be bought from the Nuclear Operative uplink

Co-authored-by: DEATHB4DEFEAT <[email protected]>
Signed-off-by: Ps3Moira <[email protected]>
@ps3moira
Copy link
Contributor Author

ps3moira commented Nov 7, 2023

Changelog
🆑

  • add: Added Mouse-Ops
  • add: Added Mouse-Ops Reinforcement Radio
  • add: Added Mouse-Ops Reinforcement Radio to Uplink

Why are there three CLs?

  • add: Added mouse operative reinforcements, which can be bought from the Nuclear Operative uplink

Fixed it

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Nov 13, 2023
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Nov 13, 2023
DEATHB4DEFEAT
DEATHB4DEFEAT previously approved these changes Nov 14, 2023
Resources/Locale/en-US/deltav/store/uplink-catalog.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/deltav/store/uplink-catalog.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/deltav/store/uplink-catalog.ftl Outdated Show resolved Hide resolved
- Syndicate
# make the player a traitor once its taken
- type: AutoTraitor
giveUplink: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ghost roles shouldn't be traitors, especially not those purchased. Reinforcements dont to this either, so a mouse especially shouldn't.

Just add them to the syndicate faction.

- type: NpcFactionMember
  factions:
    - Syndicate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does for Syndicate Reinforcement Monkey's
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'd say it's fine for mouse-ops, who can do a lot less than a monkey can do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ghost roles shouldn't be traitors, especially not those purchased. Reinforcements dont to this either, so a mouse especially shouldn't.

Just add them to the syndicate faction.

- type: NpcFactionMember
  factions:
    - Syndicate

I also added this already.

Comment on lines +12 to +14
name: Nuclear Mouse Operator Reinforcement
description: Someone needs reinforcements. You, a trained mouse, will help them.
rules: Normal syndicate antagonist rules apply. Work with whoever called you in, and don't harm them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be localized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would I do that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to localize them in the fixed branch #498

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files labels Nov 15, 2023
@github-actions github-actions bot removed Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files labels Nov 15, 2023
@ps3moira ps3moira closed this by deleting the head repository Dec 1, 2023
@ps3moira
Copy link
Contributor Author

ps3moira commented Dec 2, 2023

I closed this branch due to me accidentally messing up the code with robust tools. Bah humbug. Anyway, it's fixed, localized and ported to here #498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants